Make GTK and Aura parts orthogonal to OS parts

chrome/browser/chrome_browser_main.h

Index: chrome/browser/chrome_browser_main.h
diff --git a/chrome/browser/chrome_browser_main.h b/chrome/browser/chrome_browser_main.h
index 95f2fea609beba0ee0069fbb29108542c978d8ff..896f34462ff9070518153f679fa6d7b5538bc29d 100644
--- a/chrome/browser/chrome_browser_main.h
+++ b/chrome/browser/chrome_browser_main.h
@@ -43,13 +43,27 @@ class ChromeBrowserMainParts : public content::BrowserMainParts {
  protected:
   explicit ChromeBrowserMainParts(const MainFunctionParams& parameters);
 
+  // content::BrowserParts overrides
   virtual void PreMainMessageLoopRun() OVERRIDE;
-  int PreMainMessageLoopRunInternal();
-  virtual void MainMessageLoopRun() OVERRIDE;
   virtual void PostMainMessageLoopRun() OVERRIDE;
+
+  // content::BrowserMainParts overrides
+  virtual void MainMessageLoopRun() OVERRIDE;
   virtual void ToolkitInitialized() OVERRIDE;
 
+  // Displays a warning message that we can't find any locale data files.
+  virtual void ShowMissingLocaleMessageBox() = 0;
+  // Handles the --hide-icons and --show-icons command line options.
+  virtual int HandleIconsCommands() = 0;
+  // Check if there is any machine level Chrome installed. If so, handle it
+  // and return true.
+  virtual bool CheckMachineLevelInstall() = 0;
+  // Prepare localization, etc for handling crashes.
+  virtual void PrepareRestartOnCrashEnviroment() = 0;

[jam, 2011/10/20 18:01:19]

the last three methods are Windows specific. can we make the windows
implementation hook at the correct place (even if that means moving it slightly)
so that we don't have to put these functions on all the other platforms that
don't need it?

[stevenjb, 2011/10/21 22:25:49]

OK, I wasn't sure if there were plans for these. Made them static members of
ChromeBrowserMainPartsWin only and put them into #ifdefs. (I think at some point
we will want to break up ChromeBrowserMainParts::PreMainMessageLoopRun() and
move specialized code into the correct module, but probably not here).

Done.

+
  private:
+  int PreMainMessageLoopRunInternal();
+
   // Methods for |EarlyInitialization()| ---------------------------------------
 
   // A/B test for the maximum number of persistent connections per host.
@@ -138,9 +152,6 @@ void RecordBreakpadStatusUMA(MetricsService* metrics);
 // present on the current platform.
 void WarnAboutMinimumSystemRequirements();
 
-// Displays a warning message that we can't find any locale data files.
-void ShowMissingLocaleMessageBox();
-
 // Records the time from our process' startup to the present time in
 // the UMA histogram |metric_name|.
 void RecordBrowserStartupTime();