Make GTK and Aura parts orthogonal to OS parts

chrome/browser/chrome_browser_main.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_BROWSER_MAIN_H_
 #define CHROME_BROWSER_CHROME_BROWSER_MAIN_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
@@ skipping 25 matching lines @@
   // Constructs metrics service and does related initialization, including
   // creation of field trials. Call only after labs have been converted to
   // switches.
   MetricsService* SetupMetricsAndFieldTrials(
       const CommandLine& parsed_command_line,
       PrefService* local_state);
 
  protected:
   explicit ChromeBrowserMainParts(const MainFunctionParams& parameters);
 
+  // content::BrowserParts overrides
   virtual void PreMainMessageLoopRun() OVERRIDE;
-  int PreMainMessageLoopRunInternal();
+  virtual void PostMainMessageLoopRun() OVERRIDE;
+
+  // content::BrowserMainParts overrides
   virtual void MainMessageLoopRun() OVERRIDE;
-  virtual void PostMainMessageLoopRun() OVERRIDE;
   virtual void ToolkitInitialized() OVERRIDE;
 
+  // Displays a warning message that we can't find any locale data files.
+  virtual void ShowMissingLocaleMessageBox() = 0;
+  // Handles the --hide-icons and --show-icons command line options.
+  virtual int HandleIconsCommands() = 0;
+  // Check if there is any machine level Chrome installed. If so, handle it
+  // and return true.
+  virtual bool CheckMachineLevelInstall() = 0;
+  // Prepare localization, etc for handling crashes.
+  virtual void PrepareRestartOnCrashEnviroment() = 0;

[jam, 2011/10/20 18:01:19]

the last three methods are Windows specific. can we make the windows
implementation hook at the correct place (even if that means moving it slightly)
so that we don't have to put these functions on all the other platforms that
don't need it?

[stevenjb, 2011/10/21 22:25:49]

OK, I wasn't sure if there were plans for these. Made them static members of
ChromeBrowserMainPartsWin only and put them into #ifdefs. (I think at some point
we will want to break up ChromeBrowserMainParts::PreMainMessageLoopRun() and
move specialized code into the correct module, but probably not here).

Done.

+
  private:
+  int PreMainMessageLoopRunInternal();
+
   // Methods for |EarlyInitialization()| ---------------------------------------
 
   // A/B test for the maximum number of persistent connections per host.
   void ConnectionFieldTrial();
 
   // A/B test for determining a value for unused socket timeout.
   void SocketTimeoutFieldTrial();
 
   // A/B test for the maximum number of connections per proxy server.
   void ProxyConnectionsFieldTrial();
@@ skipping 68 matching lines @@
 // Records the conditions that can prevent Breakpad from generating and
 // sending crash reports.  The presence of a Breakpad handler (after
 // attempting to initialize crash reporting) and the presence of a debugger
 // are registered with the UMA metrics service.
 void RecordBreakpadStatusUMA(MetricsService* metrics);
 
 // Displays a warning message if some minimum level of OS support is not
 // present on the current platform.
 void WarnAboutMinimumSystemRequirements();
 
-// Displays a warning message that we can't find any locale data files.
-void ShowMissingLocaleMessageBox();
-
 // Records the time from our process' startup to the present time in
 // the UMA histogram |metric_name|.
 void RecordBrowserStartupTime();
 
 // Records a time value to an UMA histogram in the context of the
 // PreReadExperiment field-trial. This also reports to the appropriate
 // sub-histogram (_PreRead(Enabled|Disabled)).
 void RecordPreReadExperimentTime(const char* name, base::TimeDelta time);
 
 #endif  // CHROME_BROWSER_CHROME_BROWSER_MAIN_H_