Errors while deleting old version dirs no longer cause them to grow in odd ways.

Errors while deleting old version dirs no longer cause them to grow in odd ways.

InstallerState::RemoveOldVersionDirectories now tells its DeleteTreeWorkItem instances to ignore failures.  Deleting the old version dirs is a best-effort thing.  Should one fail to be deletable on account of a file or directory being in use (other than the key files: chrome.dll, npchrome_frame.dll, and chrome_frame_helper.exe), the installer will no go on its merry way rather than trying to un-do the delete (which is error-prone to say the least).

Also, during installation, don't make success of the install contingent on being able to delete old_chrome.exe.  Basically for the same reasons.  If we can't delete it because it's in use by someone/thing, just leave it there.  It'll be cleaned up on a later install, or when new_chrome.exe is later swapped into place.  This may reduce our INSTALL_FAILED errors.

BUG=100218
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105671

[robertshield, 2011-10-14 21:28:35]

LGTM, nits:

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/delete_tr...
File chrome/installer/util/delete_tree_work_item.cc (right):

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/delete_tr...
chrome/installer/util/delete_tree_work_item.cc:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
BWAHAHA!

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/installer...
File chrome/installer/util/installer_state.cc (right):

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.cc:462: VLOG(1) << "Directory found: " <<
dir_name.value();
Is this log useful to folk reading the log file?

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.cc:481: VLOG(1) << "Deleting directory: "
<< next_version.value();
"Deleting directory: " -> "Deleting old version directory: "

[grt (UTC plus 2), 2011-10-14 22:55:25]

Thanks, man.

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/delete_tr...
File chrome/installer/util/delete_tree_work_item.cc (right):

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/delete_tr...
chrome/installer/util/delete_tree_work_item.cc:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
On 2011/10/14 21:28:35, robertshield wrote:
> BWAHAHA!

My head is hung in shame.

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/installer...
File chrome/installer/util/installer_state.cc (right):

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.cc:462: VLOG(1) << "Directory found: " <<
dir_name.value();
On 2011/10/14 21:28:35, robertshield wrote:
> Is this log useful to folk reading the log file? 

Hmm.  Not so much.  Removed.

http://codereview.chromium.org/8299008/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.cc:481: VLOG(1) << "Deleting directory: "
<< next_version.value();
On 2011/10/14 21:28:35, robertshield wrote:
> "Deleting directory: " -> "Deleting old version directory: "

Done.

[commit-bot: I haz the power, 2011-10-15 00:16:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/8299008/6001

[commit-bot: I haz the power, 2011-10-15 04:26:32]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 105637, job name
was 8299008-6001 (retry) (retry) (retry) (previous was lost).

[commit-bot: I haz the power, 2011-10-15 10:44:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/8299008/6001

[commit-bot: I haz the power, 2011-10-15 13:59:27]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 105660, job name
was 8299008-6001 (retry) (retry) (retry) (retry).