Errors while deleting old version dirs no longer cause them to grow in odd ways.

chrome/installer/util/delete_tree_work_item.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

[robertshield, 2011/10/14 21:28:35]

BWAHAHA!

[grt (UTC plus 2), 2011/10/14 22:55:25]

My head is hung in shame.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/delete_tree_work_item.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 13 matching lines @@
   return true;
 }
 
 }  // namespace
 
 DeleteTreeWorkItem::DeleteTreeWorkItem(
     const FilePath& root_path,
     const FilePath& temp_path,
     const std::vector<FilePath>& key_paths)
     : root_path_(root_path),
-      temp_path_(temp_path) {
+      temp_path_(temp_path),
+      copied_to_backup_(false) {
   if (!SafeCast(key_paths.size(), &num_key_files_)) {
     NOTREACHED() << "Impossibly large key_paths collection";
   } else if (num_key_files_ != 0) {
     key_paths_.reset(new FilePath[num_key_files_]);
     key_backup_paths_.reset(new ScopedTempDir[num_key_files_]);
     std::copy(key_paths.begin(), key_paths.end(), &key_paths_[0]);
   }
 }
 
 DeleteTreeWorkItem::~DeleteTreeWorkItem() {
 }
 
 // We first try to move key_path_ to backup_path. If it succeeds, we go ahead
 // and move the rest.
 bool DeleteTreeWorkItem::Do() {
   // Go through all the key files and see if we can open them exclusively
   // with only the FILE_SHARE_DELETE flag.  Once we know we have all of them,
   // we can delete them.
   std::vector<HANDLE> opened_key_files;
   opened_key_files.reserve(num_key_files_);
   bool abort = false;
   for (ptrdiff_t i = 0; !abort && i != num_key_files_; ++i) {
     FilePath& key_file = key_paths_[i];
     ScopedTempDir& backup = key_backup_paths_[i];
-    if (!backup.CreateUniqueTempDirUnderPath(temp_path_)) {
-      PLOG(ERROR) << "Could not create temp dir in " << temp_path_.value();
-      abort = true;
-    } else if (!file_util::CopyFile(key_file,
-                   backup.path().Append(key_file.BaseName()))) {
-      PLOG(ERROR) << "Could not back up " << key_file.value()
-                  << " to directory " << backup.path().value();
-      abort = true;
-    } else {
+    if (!ignore_failure_) {
+      if (!backup.CreateUniqueTempDirUnderPath(temp_path_)) {
+        PLOG(ERROR) << "Could not create temp dir in " << temp_path_.value();
+        abort = true;
+      } else if (!file_util::CopyFile(key_file,
+                     backup.path().Append(key_file.BaseName()))) {
+        PLOG(ERROR) << "Could not back up " << key_file.value()
+                    << " to directory " << backup.path().value();
+        abort = true;
+        backup.Delete();
+      }
+    }
+    if (!abort) {
       HANDLE file = ::CreateFile(key_file.value().c_str(), FILE_ALL_ACCESS,
                                  FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0,
                                  NULL);
       if (file != INVALID_HANDLE_VALUE) {
         VLOG(1) << "Acquired exclusive lock for key file: " << key_file.value();
         opened_key_files.push_back(file);
       } else {
         if (::GetLastError() != ERROR_FILE_NOT_FOUND)
           abort = true;
         PLOG(INFO) << "Failed to open " << key_file.value();
@@ skipping 29 matching lines @@
       if (!backup_path_.CreateUniqueTempDirUnderPath(temp_path_)) {
         PLOG(ERROR) << "Failed to get backup path in folder "
                     << temp_path_.value();
         return false;
       } else {
         FilePath backup = backup_path_.path().Append(root_path_.BaseName());
         if (!file_util::CopyDirectory(root_path_, backup, true)) {
           LOG(ERROR) << "can not copy " << root_path_.value()
                      << " to backup path " << backup.value();
           return false;
+        } else {
+          copied_to_backup_ = true;
         }
       }
     }
     if (!file_util::Delete(root_path_, true)) {
       LOG(ERROR) << "can not delete " << root_path_.value();
       return ignore_failure_;
     }
   }
 
   return true;
 }
 
 // If there are files in backup paths move them back.
 void DeleteTreeWorkItem::Rollback() {
   if (ignore_failure_)
     return;
 
-  if (!backup_path_.path().empty()) {
+  if (copied_to_backup_) {
+    DCHECK(!backup_path_.path().empty());
     FilePath backup = backup_path_.path().Append(root_path_.BaseName());
     if (file_util::PathExists(backup))
       file_util::Move(backup, root_path_);
   }
 
   for (ptrdiff_t i = 0; i != num_key_files_; ++i) {
     ScopedTempDir& backup_dir = key_backup_paths_[i];
     if (!backup_dir.path().empty()) {
       FilePath& key_file = key_paths_[i];
       FilePath backup_file = backup_dir.path().Append(key_file.BaseName());
       if (file_util::PathExists(backup_file) &&
           !file_util::Move(backup_file, key_file)) {
         // This could happen if we could not delete the key file to begin with.
         PLOG(WARNING) << "Rollback: Failed to move backup file back in place: "
                       << backup_file.value() << " to " << key_file.value();
       }
     }
   }
 }