Making some CHECK statements to NOTREACHED.

chrome/browser/sync/syncable/syncable.cc

Index: chrome/browser/sync/syncable/syncable.cc
diff --git a/chrome/browser/sync/syncable/syncable.cc b/chrome/browser/sync/syncable/syncable.cc
index d974322accb30a0018fae8ca3fe96656d8471278..a162ee56b69aec7d9def9e4af6d23f35ba65d393 100644
--- a/chrome/browser/sync/syncable/syncable.cc
+++ b/chrome/browser/sync/syncable/syncable.cc
@@ -1483,7 +1483,10 @@ bool MutableEntry::PutIsDel(bool is_del) {
   }
 
   if (!is_del)
-    CHECK(PutPredecessor(Id()));  // Restores position to the 0th index.
+    // Restores position to the 0th index.
+    if (!PutPredecessor(Id())) {

[akalin, 2011/10/15 01:19:44]

TODO to propagate error up, refer bug

+      NOTREACHED();
+    }
 
   return true;
 }
@@ -1521,7 +1524,10 @@ bool MutableEntry::Put(IdField field, const Id& value) {
         return false;
     } else if (PARENT_ID == field) {
       PutParentIdPropertyOnly(value);  // Makes sibling order inconsistent.
-      CHECK(PutPredecessor(Id()));  // Fixes up the sibling order inconsistency.
+      // Fixes up the sibling order inconsistency.
+      if (!PutPredecessor(Id())) {

[akalin, 2011/10/15 01:19:44]

here too

+        NOTREACHED();
+      }
     } else {
       kernel_->put(field, value);
     }