Making some CHECK statements to NOTREACHED.

chrome/browser/sync/engine/process_commit_response_command.cc

Index: chrome/browser/sync/engine/process_commit_response_command.cc
diff --git a/chrome/browser/sync/engine/process_commit_response_command.cc b/chrome/browser/sync/engine/process_commit_response_command.cc
index 5577c9a14659b7d09423659ceec197001187eecb..e78c391479ac5c7652887e0a22072714fc33aed1 100644
--- a/chrome/browser/sync/engine/process_commit_response_command.cc
+++ b/chrome/browser/sync/engine/process_commit_response_command.cc
@@ -439,7 +439,10 @@ void ProcessCommitResponseCommand::OverrideClientFieldsAfterCommit(
     // value we got applies to the PARENT_ID we submitted.
     syncable::Id new_prev = local_entry->ComputePrevIdFromServerPosition(
         local_entry->Get(PARENT_ID));
-    CHECK(local_entry->PutPredecessor(new_prev));
+    if (!local_entry->PutPredecessor(new_prev)) {

[akalin, 2011/10/15 01:19:44]

add TODO to propagate error up, refer a bug

+      LOG(WARNING) << "PutPredecessor failed after successful commit";
+      NOTREACHED();

[akalin, 2011/10/15 01:19:44]

just do NOTREACHED() << "..."

+    }
   }
 }