Making some CHECK statements to NOTREACHED.

Convert some check statements to NOTREACHED to be on parity with the codebase that was before r104835 went in.


BUG=100374, 100398
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105670

[lipalani1, 2011-10-15 00:14:52]

This puts those statements in exactly the same state they were in before.

[akalin, 2011-10-15 00:21:24]

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/engine/buil...
File chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
(right):

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/engine/buil...
chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc:120:
return false;
maybe add NOTREACHED() so that it crashes on debug builds

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/engine/proc...
File chrome/browser/sync/engine/process_commit_response_command.cc (right):

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/engine/proc...
chrome/browser/sync/engine/process_commit_response_command.cc:443: LOG(WARNING)
<< "PutPredecessor failed after successful commit";
NOTREACHED

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/syncable/sy...
File chrome/browser/sync/syncable/syncable.cc (right):

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/syncable/sy...
chrome/browser/sync/syncable/syncable.cc:1486: PutPredecessor(Id());  //
Restores position to the 0th index.
should do something instead of silently dropped.  suggest NOTREACHED()

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/syncable/sy...
chrome/browser/sync/syncable/syncable.cc:1524: PutPredecessor(Id());  // Fixes
up the sibling order inconsistency.
NOTREACHED()

[lipalani1, 2011-10-15 00:36:31]

notreached is a good idea. implemented it. PTAL.

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/engine/buil...
File chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
(right):

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/engine/buil...
chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc:120:
return false;
On 2011/10/15 00:21:24, akalin wrote:
> maybe add NOTREACHED() so that it crashes on debug builds

Done.

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/engine/proc...
File chrome/browser/sync/engine/process_commit_response_command.cc (right):

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/engine/proc...
chrome/browser/sync/engine/process_commit_response_command.cc:443: LOG(WARNING)
<< "PutPredecessor failed after successful commit";
On 2011/10/15 00:21:24, akalin wrote:
> NOTREACHED

Done.

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/syncable/sy...
File chrome/browser/sync/syncable/syncable.cc (right):

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/syncable/sy...
chrome/browser/sync/syncable/syncable.cc:1486: PutPredecessor(Id());  //
Restores position to the 0th index.
On 2011/10/15 00:21:24, akalin wrote:
> should do something instead of silently dropped.  suggest NOTREACHED()

Done.

http://codereview.chromium.org/8298016/diff/1/chrome/browser/sync/syncable/sy...
chrome/browser/sync/syncable/syncable.cc:1524: PutPredecessor(Id());  // Fixes
up the sibling order inconsistency.
On 2011/10/15 00:21:24, akalin wrote:
> NOTREACHED()

Done.

[akalin, 2011-10-15 01:19:43]

Change subject and description to indicate that you're converting CHECKs to
NOTREACHEDs

http://codereview.chromium.org/8298016/diff/5001/chrome/browser/sync/engine/b...
File chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
(right):

http://codereview.chromium.org/8298016/diff/5001/chrome/browser/sync/engine/b...
chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc:119: if
(!entry.PutPredecessor(backup->ref(syncable::PREV_ID))) {
add TODO to propagate error up, refer to a bug

http://codereview.chromium.org/8298016/diff/5001/chrome/browser/sync/engine/p...
File chrome/browser/sync/engine/process_commit_response_command.cc (right):

http://codereview.chromium.org/8298016/diff/5001/chrome/browser/sync/engine/p...
chrome/browser/sync/engine/process_commit_response_command.cc:442: if
(!local_entry->PutPredecessor(new_prev)) {
add TODO to propagate error up, refer a bug

http://codereview.chromium.org/8298016/diff/5001/chrome/browser/sync/engine/p...
chrome/browser/sync/engine/process_commit_response_command.cc:444: NOTREACHED();
just do NOTREACHED() << "..."

http://codereview.chromium.org/8298016/diff/5001/chrome/browser/sync/syncable...
File chrome/browser/sync/syncable/syncable.cc (right):

http://codereview.chromium.org/8298016/diff/5001/chrome/browser/sync/syncable...
chrome/browser/sync/syncable/syncable.cc:1487: if (!PutPredecessor(Id())) {
TODO to propagate error up, refer bug

http://codereview.chromium.org/8298016/diff/5001/chrome/browser/sync/syncable...
chrome/browser/sync/syncable/syncable.cc:1528: if (!PutPredecessor(Id())) {
here too

[akalin, 2011-10-15 01:19:52]

LGTM after the comments above

[commit-bot: I haz the power, 2011-10-15 04:46:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lipalani@chromium.org/8298016/4006

[commit-bot: I haz the power, 2011-10-15 07:02:36]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 105645, job name
was 8298016-4006 (previous was lost) (retry) (retry) (retry).

[commit-bot: I haz the power, 2011-10-15 08:29:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lipalani@chromium.org/8298016/4006

[commit-bot: I haz the power, 2011-10-15 11:10:33]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 105658, job name
was 8298016-4006 (retry) (retry) (retry) (retry).