Support IMM32 reconversion on Windows

chrome/browser/renderer_host/render_widget_host_view_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_views.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 366 matching lines @@
   // Clamp the tooltip length to kMaxTooltipLength so that we don't
   // accidentally DOS the user with a mega tooltip.
   tooltip_text_ = ui::TruncateString(tip, kMaxTooltipLength);
   if (GetWidget())
     GetWidget()->TooltipTextChanged(this);
 }
 
 void RenderWidgetHostViewViews::SelectionChanged(const string16& text,
                                                  size_t offset,
                                                  const ui::Range& range) {
-  selection_text_ = text;
-  selection_text_offset_ = offset;
-  selection_range_ = range;
-
+  RenderWidgetHostView::SelectionChanged(text, offset, range);
   // TODO(anicolao): deal with the clipboard without GTK
   NOTIMPLEMENTED();
 }
 
 void RenderWidgetHostViewViews::SelectionBoundsChanged(
     const gfx::Rect& start_rect,
     const gfx::Rect& end_rect) {
   views::InputMethod* input_method = GetInputMethod();
 
   if (selection_start_rect_ == start_rect && selection_end_rect_ == end_rect)
@@ skipping 343 matching lines @@
 }
 
 gfx::Rect RenderWidgetHostViewViews::GetCaretBounds() {
   return selection_start_rect_.Union(selection_end_rect_);
 }
 
 bool RenderWidgetHostViewViews::HasCompositionText() {
   return has_composition_text_;
 }
 
 bool RenderWidgetHostViewViews::GetTextRange(ui::Range* range) {

[Hironori Bono, 2011/10/27 06:17:47]

nit: I prefer adding 'DCHECK(range)' here.

[Peng, 2011/10/27 16:12:24]

I used those kind of DHCECK() for input arguments. But some reviewer told me it
is not necessary. They think crash in function can be found and resolved easily,
even if without DCHECK(). So I removed them.

http://codereview.chromium.org/8294026/diff/22016/chrome/browser/renderer_hos...

-  // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
-  NOTIMPLEMENTED();
-  return false;
+  *range = ui::Range(selection_text_offset_,

[Hironori Bono, 2011/10/27 06:17:47]

nit: can we use operator= for ui::Range? In general, Google coding style does
not encourage using copy constructors
<http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Copy_C...>.

[Peng, 2011/10/27 16:12:24]

Done.

[Peng, 2011/10/27 16:12:24]

Done.

+                     selection_text_offset_ + selection_text_.length());
+  return true;
 }
 
 bool RenderWidgetHostViewViews::GetCompositionTextRange(ui::Range* range) {
   // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
   NOTIMPLEMENTED();
   return false;
 }
 
 bool RenderWidgetHostViewViews::GetSelectionRange(ui::Range* range) {

[Hironori Bono, 2011/10/27 06:17:47]

nit: I prefer adding 'DCHECK(range)' here.

[Peng, 2011/10/27 16:12:24]

ditto

-  // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
-  NOTIMPLEMENTED();
-  return false;
+  *range = selection_range_;

[Hironori Bono, 2011/10/27 06:17:47]

nit: if ui::Range explicitly allows using copy constructors, I prefer replacing
it with set_start() and set_end().

[Peng, 2011/10/27 16:12:24]

Done.

+  return true;
 }
 
 bool RenderWidgetHostViewViews::SetSelectionRange(const ui::Range& range) {
   // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
   NOTIMPLEMENTED();
   return false;
 }
 
 bool RenderWidgetHostViewViews::DeleteRange(const ui::Range& range) {
   // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
   NOTIMPLEMENTED();
   return false;
 }
 
 bool RenderWidgetHostViewViews::GetTextFromRange(
     const ui::Range& range,
-    const base::Callback<void(const string16&)>& callback) {
-  // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
-  NOTIMPLEMENTED();
-  return false;
+    string16* text) {

[Hironori Bono, 2011/10/27 06:17:47]

nit: I prefer adding 'DCHECK(text)' here.

[Peng, 2011/10/27 16:12:24]

ditto

+  ui::Range selection_text_range(selection_text_offset_,
+      selection_text_offset_ + selection_text_.length());
+
+  if (!selection_text_range.Contains(range)) {
+    text->clear();
+    return false;
+  }
+
+  if (range.GetMin() == selection_text_range.start() &&
+      range.GetMax() == selection_text_range.end()) {
+    // Avoid calling substr which performance is low.
+    *text = selection_text_;
+  } else {
+    *text = selection_text_.substr(
+        range.GetMin() - selection_text_offset_,
+        range.length());
+  }
+  return true;
 }
 
 void RenderWidgetHostViewViews::OnInputMethodChanged() {
   if (!host_)
     return;
 
   DCHECK(GetInputMethod());
   host_->SetInputMethodActive(GetInputMethod()->IsActive());
 
   // TODO(suzhe): implement the newly added “locale” property of HTML DOM
@@ skipping 358 matching lines @@
   for (std::vector< base::Callback<void(void)> >::const_iterator
       it = on_compositing_ended_callbacks_.begin();
       it != on_compositing_ended_callbacks_.end(); ++it) {
     it->Run();
   }
   on_compositing_ended_callbacks_.clear();
   compositor->RemoveObserver(this);
 }
 
 #endif