Support IMM32 reconversion on Windows

chrome/browser/renderer_host/render_widget_host_view_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_views.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 734 matching lines @@
 
 gfx::Rect RenderWidgetHostViewViews::GetCaretBounds() {
   return selection_start_rect_.Union(selection_end_rect_);
 }
 
 bool RenderWidgetHostViewViews::HasCompositionText() {
   return has_composition_text_;
 }
 
 bool RenderWidgetHostViewViews::GetTextRange(ui::Range* range) {
-  // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
-  NOTIMPLEMENTED();
-  return false;
+  DCHECK(range);

[jam, 2011/10/25 00:32:13]

nit: we avoid DCHECKING pointers before using them. in release builds this does
nothing. in debug the crash in the next line is just as useful

[Peng, 2011/10/25 15:51:39]

Done.

+  *range = ui::Range(selection_text_offset_,
+                     selection_text_offset_ + selection_text_.length());
+  return true;
 }
 
 bool RenderWidgetHostViewViews::GetCompositionTextRange(ui::Range* range) {
   // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
   NOTIMPLEMENTED();
   return false;
 }
 
 bool RenderWidgetHostViewViews::GetSelectionRange(ui::Range* range) {
-  // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
-  NOTIMPLEMENTED();
-  return false;
+  DCHECK(range);
+  *range = selection_range_;
+  return true;
 }
 
 bool RenderWidgetHostViewViews::SetSelectionRange(const ui::Range& range) {
   // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
   NOTIMPLEMENTED();
   return false;
 }
 
 bool RenderWidgetHostViewViews::DeleteRange(const ui::Range& range) {
   // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
   NOTIMPLEMENTED();
   return false;
 }
 
 bool RenderWidgetHostViewViews::GetTextFromRange(
     const ui::Range& range,
-    const base::Callback<void(const string16&)>& callback) {
-  // TODO(suzhe): implement this method when fixing http://crbug.com/55130.
-  NOTIMPLEMENTED();
-  return false;
+    string16* text,
+    ui::Range* actual_range) {
+  ui::Range selection_text_range(
+      selection_text_offset_,
+      selection_text_offset_ + selection_text_.length());
+  *actual_range = selection_text_range.Intersect(range);
+
+  if (!actual_range->IsValid() || actual_range->is_empty()) {
+    text->clear();
+  } else {
+    *text = selection_text_.substr(
+        actual_range->GetMin() - selection_text_offset_,
+        actual_range->length());
+  }
+
+  return true;
 }
 
 void RenderWidgetHostViewViews::OnInputMethodChanged() {
   if (!host_)
     return;
 
   DCHECK(GetInputMethod());
   host_->SetInputMethodActive(GetInputMethod()->IsActive());
 
   // TODO(suzhe): implement the newly added “locale” property of HTML DOM
@@ skipping 359 matching lines @@
   for (std::vector< base::Callback<void(void)> >::const_iterator
       it = on_compositing_ended_callbacks_.begin();
       it != on_compositing_ended_callbacks_.end(); ++it) {
     it->Run();
   }
   on_compositing_ended_callbacks_.clear();
   compositor->RemoveObserver(this);
 }
 
 #endif