|
Merge 105121 - Numerous fixes to audio/video buffered resource loading.
This patch fixes a few related issues:
1) Default loading strategy is now threshold-then-defer
2) Specify more reasonable default bitrate/playback rate values
3) Use a minimum buffer window size to prevent underflows on low bitrate content
4) Remember bitrate/playback rate values between resource loaders
The default loading strategy of read-then-defer had a negative impact on initial latency as we were constantly deferring/undeferring the connection during the time when we need data the fastest.
While this change does result in loading a pinch more data for preload=metadata scenarios, it vastly improves the common preload=auto scenario.
BUG= 99775
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/8224028
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105963
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+604 lines, -71 lines) |
Patch |
|
M |
media/base/filters.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
media/base/mock_filters.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
media/base/seekable_buffer.h
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
media/filters/ffmpeg_demuxer.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
media/filters/ffmpeg_demuxer.cc
|
View
|
|
2 chunks |
+38 lines, -3 lines |
0 comments
|
Download
|
|
M |
media/filters/ffmpeg_demuxer_unittest.cc
|
View
|
|
4 chunks |
+36 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/filters/file_data_source.h
|
View
|
|
3 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
|
M |
media/filters/file_data_source.cc
|
View
|
|
3 chunks |
+20 lines, -8 lines |
0 comments
|
Download
|
|
M |
webkit/glue/media/buffered_data_source.h
|
View
|
|
4 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
webkit/glue/media/buffered_data_source.cc
|
View
|
|
7 chunks |
+31 lines, -16 lines |
0 comments
|
Download
|
|
M |
webkit/glue/media/buffered_data_source_unittest.cc
|
View
|
1
|
4 chunks |
+195 lines, -1 line |
0 comments
|
Download
|
|
M |
webkit/glue/media/buffered_resource_loader.h
|
View
|
|
3 chunks |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
webkit/glue/media/buffered_resource_loader.cc
|
View
|
|
6 chunks |
+106 lines, -19 lines |
0 comments
|
Download
|
|
M |
webkit/glue/media/buffered_resource_loader_unittest.cc
|
View
|
|
9 chunks |
+113 lines, -21 lines |
0 comments
|
Download
|
|
M |
webkit/glue/media/simple_data_source.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
webkit/glue/media/simple_data_source.cc
|
View
|
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
|