Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8291005: HQP Refactoring (in Preparation for SQLite Cache) (Closed)

Created:
9 years, 2 months ago by mrossetti
Modified:
9 years, 2 months ago
Reviewers:
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., James Su, tim (not reviewing)
Visibility:
Public.

Description

HQP Refactoring (in Preparation for SQLite Cache) 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson,brettw Previously reviewed and LG'ed as http://codereview.chromium.org/8120004/. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105678

Patch Set 1 #

Patch Set 2 : Rattle those Bots Senseless #

Unified diffs Side-by-side diffs Delta from patch set Stats (+986 lines, -690 lines) Patch
M chrome/browser/autocomplete/autocomplete.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 1 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 2 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/history/history.cc View 1 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 5 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 6 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/history/history_notifications.h View 1 4 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/history/history_types.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.cc View 1 3 chunks +7 lines, -29 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.h View 1 10 chunks +33 lines, -139 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 32 chunks +234 lines, -266 lines 0 comments Download
A chrome/browser/history/in_memory_url_index_types.h View 1 chunk +206 lines, -0 lines 0 comments Download
A chrome/browser/history/in_memory_url_index_types.cc View 1 chunk +197 lines, -0 lines 0 comments Download
A chrome/browser/history/in_memory_url_index_types_unittest.cc View 1 chunk +107 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_url_index_unittest.cc View 1 18 chunks +106 lines, -194 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/cancelable_request.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698