Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3862)

Unified Diff: chrome/browser/history/history_notifications.h

Issue 8291005: HQP Refactoring (in Preparation for SQLite Cache) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rattle those Bots Senseless Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_notifications.h
===================================================================
--- chrome/browser/history/history_notifications.h (revision 105497)
+++ chrome/browser/history/history_notifications.h (working copy)
@@ -25,7 +25,7 @@
virtual ~HistoryDetails() {}
};
-// Details for HISTORY_URL_VISITED.
+// Details for NOTIFICATION_HISTORY_URL_VISITED.
struct URLVisitedDetails : public HistoryDetails {
URLVisitedDetails();
virtual ~URLVisitedDetails();
@@ -40,7 +40,7 @@
history::RedirectList redirects;
};
-// Details for NOTIFY_HISTORY_TYPED_URLS_MODIFIED.
+// Details for NOTIFICATION_HISTORY_TYPED_URLS_MODIFIED.
struct URLsModifiedDetails : public HistoryDetails {
URLsModifiedDetails();
virtual ~URLsModifiedDetails();
@@ -49,7 +49,7 @@
std::vector<URLRow> changed_urls;
};
-// Details for NOTIFY_HISTORY_URLS_DELETED.
+// Details for NOTIFICATION_HISTORY_URLS_DELETED.
struct URLsDeletedDetails : public HistoryDetails {
URLsDeletedDetails();
virtual ~URLsDeletedDetails();
@@ -57,9 +57,14 @@
// Set when all history was deleted. False means just a subset was deleted.
bool all_history;
+ // The URLRows which have been deleted.
+ std::vector<URLRow> rows;
+
// The list of unique URLs affected. This is valid only when a subset of
// history is deleted. When all of it is deleted, this will be empty, since
- // we do not bother to list all URLs.
+ // we do not bother to list all URLs. (This information can be gleaned from
+ // |rows| but, since there are several clients who need the set, we pre-build
+ // it so that the clients don't have to.)
std::set<GURL> urls;
};
« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698