Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 8289021: chromeos: Change all clients of LoginLibrary to use SessionManagerClient. (Closed)

Created:
9 years, 2 months ago by satorux1
Modified:
9 years, 2 months ago
Reviewers:
Chris Masone, stevenjb
CC:
chromium-reviews, stevenjb, nkostylev+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Change all clients of LoginLibrary to use SessionManagerClient. This is part 2 of the LoginLibrary to SessionManagerClient migration. LoginLibrary will be removed in the next patch. BUG=chromium-os:16555 TEST=confirm that the login and logout works as before Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106172

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebase #

Patch Set 4 : reupload #

Patch Set 5 : renamed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -150 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dbus/dbus_thread_manager.h View 1 2 3 4 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dbus/dbus_thread_manager.cc View 1 2 3 4 4 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/chromeos/enterprise_extension_observer.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 4 4 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen_browsertest.cc View 1 2 3 4 4 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings.cc View 8 chunks +17 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_helper_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_unittest.cc View 1 2 3 4 17 chunks +37 lines, -71 lines 0 comments Download
M chrome/browser/chromeos/login/update_screen_browsertest.cc View 1 2 3 4 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
9 years, 2 months ago (2011-10-15 00:04:25 UTC) #1
satorux1
Chris, could you take a look at this as well? Touching many files, but most ...
9 years, 2 months ago (2011-10-18 18:47:39 UTC) #2
Chris Masone
On 2011/10/18 18:47:39, satorux1 wrote: > Chris, could you take a look at this as ...
9 years, 2 months ago (2011-10-18 20:42:46 UTC) #3
stevenjb
9 years, 2 months ago (2011-10-18 20:49:02 UTC) #4
Ahh, much nicer.
LGTM

Powered by Google App Engine
This is Rietveld 408576698