Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 8289021: chromeos: Change all clients of LoginLibrary to use SessionManagerClient. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: renamed Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/string16.h" 9 #include "base/string16.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/browser/chromeos/cros/cros_library.h" 12 #include "chrome/browser/chromeos/cros/cros_library.h"
13 #include "chrome/browser/chromeos/cros/mock_login_library.h" 13 #include "chrome/browser/chromeos/dbus/dbus_thread_manager.h"
14 #include "chrome/browser/chromeos/dbus/mock_session_manager_client.h"
14 #include "chrome/browser/chromeos/cros/mock_network_library.h" 15 #include "chrome/browser/chromeos/cros/mock_network_library.h"
15 #include "chrome/browser/chromeos/cros/network_library.h" 16 #include "chrome/browser/chromeos/cros/network_library.h"
16 #include "chrome/browser/chromeos/login/mock_screen_observer.h" 17 #include "chrome/browser/chromeos/login/mock_screen_observer.h"
17 #include "chrome/browser/chromeos/login/network_screen.h" 18 #include "chrome/browser/chromeos/login/network_screen.h"
18 #include "chrome/browser/chromeos/login/network_selection_view.h" 19 #include "chrome/browser/chromeos/login/network_selection_view.h"
19 #include "chrome/browser/chromeos/login/view_screen.h" 20 #include "chrome/browser/chromeos/login/view_screen.h"
20 #include "chrome/browser/chromeos/login/views_network_screen_actor.h" 21 #include "chrome/browser/chromeos/login/views_network_screen_actor.h"
21 #include "chrome/browser/chromeos/login/wizard_controller.h" 22 #include "chrome/browser/chromeos/login/wizard_controller.h"
22 #include "chrome/browser/chromeos/login/wizard_in_process_browser_test.h" 23 #include "chrome/browser/chromeos/login/wizard_in_process_browser_test.h"
23 #include "chrome/browser/chromeos/login/wizard_screen.h" 24 #include "chrome/browser/chromeos/login/wizard_screen.h"
(...skipping 15 matching lines...) Expand all
39 40
40 class DummyButtonListener : public views::ButtonListener { 41 class DummyButtonListener : public views::ButtonListener {
41 public: 42 public:
42 virtual void ButtonPressed(views::Button* sender, 43 virtual void ButtonPressed(views::Button* sender,
43 const views::Event& event) {} 44 const views::Event& event) {}
44 }; 45 };
45 46
46 class NetworkScreenTest : public WizardInProcessBrowserTest { 47 class NetworkScreenTest : public WizardInProcessBrowserTest {
47 public: 48 public:
48 NetworkScreenTest(): WizardInProcessBrowserTest("network"), 49 NetworkScreenTest(): WizardInProcessBrowserTest("network"),
49 mock_login_library_(NULL), 50 mock_session_manager_client_(NULL),
50 mock_network_library_(NULL) { 51 mock_network_library_(NULL) {
51 } 52 }
52 53
53 protected: 54 protected:
54 virtual void SetUpInProcessBrowserTestFixture() { 55 virtual void SetUpInProcessBrowserTestFixture() {
56 DBusThreadManager::Initialize();
55 cros_mock_->InitStatusAreaMocks(); 57 cros_mock_->InitStatusAreaMocks();
56 mock_network_library_ = cros_mock_->mock_network_library(); 58 mock_network_library_ = cros_mock_->mock_network_library();
57 mock_login_library_ = new MockLoginLibrary(); 59 mock_session_manager_client_ = new MockSessionManagerClient();
60 DBusThreadManager::Get()->set_session_manager_client_for_testing(
61 mock_session_manager_client_);
58 cellular_.reset(new NetworkDevice("cellular")); 62 cellular_.reset(new NetworkDevice("cellular"));
59 cros_mock_->test_api()->SetLoginLibrary(mock_login_library_, true); 63 EXPECT_CALL(*mock_session_manager_client_, EmitLoginPromptReady())
60 EXPECT_CALL(*mock_login_library_, EmitLoginPromptReady())
61 .Times(1); 64 .Times(1);
62 EXPECT_CALL(*mock_login_library_,RequestRetrievePolicy(_,_)) 65 EXPECT_CALL(*mock_session_manager_client_, RetrievePolicy(_))
63 .Times(AnyNumber()); 66 .Times(AnyNumber());
64 67
65 // Minimal set of expectations needed on NetworkScreen initialization. 68 // Minimal set of expectations needed on NetworkScreen initialization.
66 // Status bar expectations are defined with RetiresOnSaturation() so 69 // Status bar expectations are defined with RetiresOnSaturation() so
67 // these mocks will be active once status bar is initialized. 70 // these mocks will be active once status bar is initialized.
68 EXPECT_CALL(*mock_network_library_, ethernet_connected()) 71 EXPECT_CALL(*mock_network_library_, ethernet_connected())
69 .Times(2) 72 .Times(2)
70 .WillRepeatedly(Return(false)); 73 .WillRepeatedly(Return(false));
71 EXPECT_CALL(*mock_network_library_, ethernet_connecting()) 74 EXPECT_CALL(*mock_network_library_, ethernet_connecting())
72 .Times(2) 75 .Times(2)
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 network_screen_->screen_observer_ = mock_screen_observer_.get(); 127 network_screen_->screen_observer_ = mock_screen_observer_.get();
125 // We need a couple of methods defined only in views version. 128 // We need a couple of methods defined only in views version.
126 // TODO(avayvod): Refactor this when WebUI implementation is finished. 129 // TODO(avayvod): Refactor this when WebUI implementation is finished.
127 actor_ = static_cast<ViewsNetworkScreenActor*>(network_screen_->actor()); 130 actor_ = static_cast<ViewsNetworkScreenActor*>(network_screen_->actor());
128 ASSERT_TRUE(actor_ != NULL); 131 ASSERT_TRUE(actor_ != NULL);
129 } 132 }
130 133
131 virtual void TearDownInProcessBrowserTestFixture() { 134 virtual void TearDownInProcessBrowserTestFixture() {
132 network_screen_->screen_observer_ = controller(); 135 network_screen_->screen_observer_ = controller();
133 CrosInProcessBrowserTest::TearDownInProcessBrowserTestFixture(); 136 CrosInProcessBrowserTest::TearDownInProcessBrowserTestFixture();
134 cros_mock_->test_api()->SetLoginLibrary(NULL, false); 137 DBusThreadManager::Shutdown();
135 } 138 }
136 139
137 void EmulateContinueButtonExit(NetworkScreen* network_screen) { 140 void EmulateContinueButtonExit(NetworkScreen* network_screen) {
138 EXPECT_CALL(*mock_screen_observer_, 141 EXPECT_CALL(*mock_screen_observer_,
139 OnExit(ScreenObserver::NETWORK_CONNECTED)) 142 OnExit(ScreenObserver::NETWORK_CONNECTED))
140 .Times(1); 143 .Times(1);
141 EXPECT_CALL(*mock_network_library_, Connected()) 144 EXPECT_CALL(*mock_network_library_, Connected())
142 .WillOnce(Return(true)); 145 .WillOnce(Return(true));
143 network_screen->OnContinuePressed(); 146 network_screen->OnContinuePressed();
144 ui_test_utils::RunAllPendingInMessageLoop(); 147 ui_test_utils::RunAllPendingInMessageLoop();
145 } 148 }
146 149
147 scoped_ptr<MockScreenObserver> mock_screen_observer_; 150 scoped_ptr<MockScreenObserver> mock_screen_observer_;
148 MockLoginLibrary* mock_login_library_; 151 MockSessionManagerClient* mock_session_manager_client_;
149 MockNetworkLibrary* mock_network_library_; 152 MockNetworkLibrary* mock_network_library_;
150 scoped_ptr<NetworkDevice> cellular_; 153 scoped_ptr<NetworkDevice> cellular_;
151 NetworkScreen* network_screen_; 154 NetworkScreen* network_screen_;
152 ViewsNetworkScreenActor* actor_; 155 ViewsNetworkScreenActor* actor_;
153 156
154 private: 157 private:
155 DISALLOW_COPY_AND_ASSIGN(NetworkScreenTest); 158 DISALLOW_COPY_AND_ASSIGN(NetworkScreenTest);
156 }; 159 };
157 160
158 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Ethernet) { 161 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Ethernet) {
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 EXPECT_FALSE(actor_->IsConnecting()); 279 EXPECT_FALSE(actor_->IsConnecting());
277 network_screen_->OnConnectionTimeout(); 280 network_screen_->OnConnectionTimeout();
278 281
279 // Close infobubble with error message - it makes the test stable. 282 // Close infobubble with error message - it makes the test stable.
280 EXPECT_FALSE(actor_->IsContinueEnabled()); 283 EXPECT_FALSE(actor_->IsContinueEnabled());
281 EXPECT_FALSE(actor_->IsConnecting()); 284 EXPECT_FALSE(actor_->IsConnecting());
282 actor_->ClearErrors(); 285 actor_->ClearErrors();
283 } 286 }
284 287
285 } // namespace chromeos 288 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/login_utils.cc ('k') | chrome/browser/chromeos/login/screen_locker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698