Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8283014: Sync: Update look of sign in box (Closed)

Created:
9 years, 2 months ago by sail
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Sync: Update look of sign in box Screenshots: http://www.dropmocks.com/mbIc- BUG=93177 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105721

Patch Set 1 #

Patch Set 2 : remove comment #

Patch Set 3 : update #

Patch Set 4 : promo page #

Total comments: 16

Patch Set 5 : address review comments #

Total comments: 37

Patch Set 6 : addressed review comments #

Patch Set 7 : RTL #

Patch Set 8 : fixed create account text #

Total comments: 2

Patch Set 9 : addressed review comments #

Patch Set 10 : removing binary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -374 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 7 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/sync_promo.css View 1 2 3 4 5 6 5 chunks +40 lines, -29 lines 0 comments Download
M chrome/browser/resources/sync_promo.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.css View 1 2 3 4 5 6 5 chunks +248 lines, -64 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.html View 1 2 3 4 5 6 7 2 chunks +112 lines, -242 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.js View 1 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/enterprise_enrollment_ui_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enterprise_enrollment_screen_handler.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 3 4 5 6 7 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
sail
9 years, 2 months ago (2011-10-13 23:03:26 UTC) #1
sail
Everything works now. The only thing left is to fix the error blurb so that ...
9 years, 2 months ago (2011-10-14 21:43:41 UTC) #2
sail
Adding binji as well.
9 years, 2 months ago (2011-10-14 21:43:59 UTC) #3
James Hawkins
http://codereview.chromium.org/8283014/diff/6009/chrome/browser/resources/sync_promo.css File chrome/browser/resources/sync_promo.css (right): http://codereview.chromium.org/8283014/diff/6009/chrome/browser/resources/sync_promo.css#newcode37 chrome/browser/resources/sync_promo.css:37: margin: 0 385px 0 0; Just set margin-right? http://codereview.chromium.org/8283014/diff/6009/chrome/browser/resources/sync_promo.css#newcode70 ...
9 years, 2 months ago (2011-10-14 21:52:10 UTC) #4
sail
Fixed, please take another look. http://codereview.chromium.org/8283014/diff/6009/chrome/browser/resources/sync_promo.css File chrome/browser/resources/sync_promo.css (right): http://codereview.chromium.org/8283014/diff/6009/chrome/browser/resources/sync_promo.css#newcode37 chrome/browser/resources/sync_promo.css:37: margin: 0 385px 0 ...
9 years, 2 months ago (2011-10-14 22:11:36 UTC) #5
binji
http://codereview.chromium.org/8283014/diff/6009/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8283014/diff/6009/chrome/app/generated_resources.grd#newcode10198 chrome/app/generated_resources.grd:10198: <message name="IDS_SYNC_CREATE_ACCOUNT_PREFIX" desc="The text before the create account link"> ...
9 years, 2 months ago (2011-10-14 22:18:43 UTC) #6
James Hawkins
http://codereview.chromium.org/8283014/diff/12001/chrome/browser/resources/sync_promo.css File chrome/browser/resources/sync_promo.css (right): http://codereview.chromium.org/8283014/diff/12001/chrome/browser/resources/sync_promo.css#newcode37 chrome/browser/resources/sync_promo.css:37: margin-right: 385px; RTL http://codereview.chromium.org/8283014/diff/12001/chrome/browser/resources/sync_promo.css#newcode76 chrome/browser/resources/sync_promo.css:76: font-weight: normal; Alphabetize http://codereview.chromium.org/8283014/diff/12001/chrome/browser/resources/sync_setup_overlay.css ...
9 years, 2 months ago (2011-10-14 22:21:36 UTC) #7
sail
http://codereview.chromium.org/8283014/diff/12001/chrome/browser/resources/sync_promo.css File chrome/browser/resources/sync_promo.css (right): http://codereview.chromium.org/8283014/diff/12001/chrome/browser/resources/sync_promo.css#newcode76 chrome/browser/resources/sync_promo.css:76: font-weight: normal; On 2011/10/14 22:21:36, James Hawkins wrote: > ...
9 years, 2 months ago (2011-10-14 22:57:05 UTC) #8
sail
Working on fixing RTL issues.
9 years, 2 months ago (2011-10-14 22:57:45 UTC) #9
sail
RTL issues fixed. Screenshots: http://www.dropmocks.com/mbLNy Please take another look. Thanks! http://codereview.chromium.org/8283014/diff/12001/chrome/browser/resources/sync_promo.css File chrome/browser/resources/sync_promo.css (right): http://codereview.chromium.org/8283014/diff/12001/chrome/browser/resources/sync_promo.css#newcode37 ...
9 years, 2 months ago (2011-10-15 00:28:47 UTC) #10
sail
http://codereview.chromium.org/8283014/diff/6009/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8283014/diff/6009/chrome/app/generated_resources.grd#newcode10198 chrome/app/generated_resources.grd:10198: <message name="IDS_SYNC_CREATE_ACCOUNT_PREFIX" desc="The text before the create account link"> ...
9 years, 2 months ago (2011-10-15 01:01:37 UTC) #11
binji
lgtm w/ nit http://codereview.chromium.org/8283014/diff/14024/chrome/browser/resources/sync_promo.html File chrome/browser/resources/sync_promo.html (right): http://codereview.chromium.org/8283014/diff/14024/chrome/browser/resources/sync_promo.html#newcode18 chrome/browser/resources/sync_promo.html:18: +<link rel="stylesheet" href="chrome://resources/css/button.css"> Remove +
9 years, 2 months ago (2011-10-15 01:32:56 UTC) #12
sail
http://codereview.chromium.org/8283014/diff/14024/chrome/browser/resources/sync_promo.html File chrome/browser/resources/sync_promo.html (right): http://codereview.chromium.org/8283014/diff/14024/chrome/browser/resources/sync_promo.html#newcode18 chrome/browser/resources/sync_promo.html:18: +<link rel="stylesheet" href="chrome://resources/css/button.css"> On 2011/10/15 01:32:56, binji wrote: > ...
9 years, 2 months ago (2011-10-15 04:28:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8283014/9016
9 years, 2 months ago (2011-10-16 03:56:33 UTC) #14
commit-bot: I haz the power
Try job failure for 8283014-9016 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years, 2 months ago (2011-10-16 04:20:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8283014/19001
9 years, 2 months ago (2011-10-16 04:24:28 UTC) #16
commit-bot: I haz the power
9 years, 2 months ago (2011-10-16 05:33:24 UTC) #17 
Change committed as 105721

Powered by Google App Engine
This is Rietveld 408576698