Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/renderer/extensions/chrome_v8_extension.h

Issue 8277020: Stop copying extension bindings scripts. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | chrome/renderer/extensions/chrome_v8_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/chrome_v8_extension.h
diff --git a/chrome/renderer/extensions/chrome_v8_extension.h b/chrome/renderer/extensions/chrome_v8_extension.h
index 0b6d20c91b9ad3c8b203d0ffb4ab85a0834d6889..d156ce74900562fd56fc4b52cf6efdd32de1bc28 100644
--- a/chrome/renderer/extensions/chrome_v8_extension.h
+++ b/chrome/renderer/extensions/chrome_v8_extension.h
@@ -93,7 +93,8 @@ class ChromeV8Extension : public v8::Extension {
ExtensionDispatcher* extension_dispatcher_;
private:
- static const char* GetStringResource(int resource_id);
+ static base::StringPiece GetStringResourceAsStringPiece(int resource_id);
Aaron Boodman 2011/10/14 21:41:09 Nit: No need to encode the returned type in the na
+ static int GetStringResourceLength(int resource_id);
Aaron Boodman 2011/10/14 21:41:09 Nit: I don't think it's worth having this extra me
// Helper to print from bindings javascript.
static v8::Handle<v8::Value> Print(const v8::Arguments& args);
« no previous file with comments | « DEPS ('k') | chrome/renderer/extensions/chrome_v8_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698