Chromium Code Reviews| Index: chrome/renderer/extensions/chrome_v8_extension.h |
| diff --git a/chrome/renderer/extensions/chrome_v8_extension.h b/chrome/renderer/extensions/chrome_v8_extension.h |
| index 0b6d20c91b9ad3c8b203d0ffb4ab85a0834d6889..d156ce74900562fd56fc4b52cf6efdd32de1bc28 100644 |
| --- a/chrome/renderer/extensions/chrome_v8_extension.h |
| +++ b/chrome/renderer/extensions/chrome_v8_extension.h |
| @@ -93,7 +93,8 @@ class ChromeV8Extension : public v8::Extension { |
| ExtensionDispatcher* extension_dispatcher_; |
| private: |
| - static const char* GetStringResource(int resource_id); |
| + static base::StringPiece GetStringResourceAsStringPiece(int resource_id); |
|
Aaron Boodman
2011/10/14 21:41:09
Nit: No need to encode the returned type in the na
|
| + static int GetStringResourceLength(int resource_id); |
|
Aaron Boodman
2011/10/14 21:41:09
Nit: I don't think it's worth having this extra me
|
| // Helper to print from bindings javascript. |
| static v8::Handle<v8::Value> Print(const v8::Arguments& args); |