Issue 8276023: IndexedDB: Wrong exception types thrown for invalid keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8276023: IndexedDB: Wrong exception types thrown for invalid keys (Closed)

Created:
9 years, 2 months ago by jsbell

Modified:
9 years, 1 month ago

Reviewers:
hans, darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org, dgrogan

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

IndexedDB: Wrong exception types thrown for invalid keys Chromium side of WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=70065 This drops the Chromium dependency on WebIDBKey::NullType and treats it the same as WebIDBKey::InvalidType. Once this has landed, the second half of the WebKit side can go in and (finally) the default: cases herein ensuring all enumeration parameters are handled can be removed. BUG=98930 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107744

Patch Set 1 #

Patch Set 2 : Updated copyright years #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -12 lines)			Patch
M	content/common/indexed_db_key.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/indexed_db_key.cc	View	1	4 chunks	+2 lines, -7 lines	0 comments	Download
M	content/common/indexed_db_param_traits.cc	View	1	3 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages