Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Unified Diff: content/common/indexed_db_key.cc

Issue 8276023: IndexedDB: Wrong exception types thrown for invalid keys (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Updated copyright years Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/indexed_db_key.h ('k') | content/common/indexed_db_param_traits.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/indexed_db_key.cc
diff --git a/content/common/indexed_db_key.cc b/content/common/indexed_db_key.cc
index ee02fa136d04e61131372aceaf84baa7fa1c6183..c4e0b20d6c3e72386ad1a5fcba6e5050788c5d79 100644
--- a/content/common/indexed_db_key.cc
+++ b/content/common/indexed_db_key.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -22,10 +22,6 @@ IndexedDBKey::IndexedDBKey(const WebIDBKey& key) {
IndexedDBKey::~IndexedDBKey() {
}
-void IndexedDBKey::SetNull() {
- type_ = WebIDBKey::NullType;
-}
-
void IndexedDBKey::SetInvalid() {
type_ = WebIDBKey::InvalidType;
}
@@ -55,8 +51,6 @@ void IndexedDBKey::Set(const WebIDBKey& key) {
IndexedDBKey::operator WebIDBKey() const {
switch (type_) {
- case WebIDBKey::NullType:
- return WebIDBKey::createNull();
case WebIDBKey::StringType:
return WebIDBKey::createString(string_);
case WebIDBKey::DateType:
@@ -64,6 +58,7 @@ IndexedDBKey::operator WebIDBKey() const {
case WebIDBKey::NumberType:
return WebIDBKey::createNumber(number_);
case WebIDBKey::InvalidType:
+ default: // TODO(jsbell): Remove this case label once NullType is gone
return WebIDBKey::createInvalid();
}
NOTREACHED();
« no previous file with comments | « content/common/indexed_db_key.h ('k') | content/common/indexed_db_param_traits.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698