src/trusted/service_runtime/arch/arm/nacl_switch_to_app_arm.c - Issue 8275008: Make validator require read sandboxing on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/arch/arm/nacl_switch_to_app_arm.c

Issue 8275008: Make validator require read sandboxing on ARM. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/service_runtime/arch/arm/nacl_switch_to_app_arm.c

===================================================================

--- src/trusted/service_runtime/arch/arm/nacl_switch_to_app_arm.c (revision 6937)

+++ src/trusted/service_runtime/arch/arm/nacl_switch_to_app_arm.c (working copy)

@@ -44,8 +44,7 @@

CHECK((nap->user_entry_pt & 0x1) | (nap->initial_entry_pt & 0x1));

/* The real springboard target addresses are aligned 0xe mod 16. */

- /* Skipping a 2-byte halt brings us to 0 mod 16. */

robertm 2011/10/18 21:19:55 this change was not mentioned in the description

sehr (please use chromium) 2011/10/18 22:44:11 Thanks. This was not intended for this CL.

- CHECK((nap->springboard_addr & 0xf) == 0x0);

+ CHECK((nap->springboard_addr & 0xf) == 0xe);

return nap->springboard_addr | 0x1;

#else

return nap->springboard_addr;