PPAPI Fullscreen: In ViewChanged, check if the browser entered fullscreen mode

PPAPI Fullscreen: In ViewChanged, check if the browser entered fullscreen mode
and if the current element is the fullscreen element. This will help us
determine more reliably if the plugin entered/exited fullscreen mode. This
also takes care of the F11 case where desired_fullscree_state_ has not been
properly set.

Add a dummy stub for RenderWidget::is_fullscreen to be implemented
by darin in a different patch) and wrappers for it to make it available
via PluginDelegate::IsInFullscreenMode to the PluginInstance.

BUG=41780, 98477
TEST=ppapi_tests/test_fullscreen, native_client/tests/ppapi_browser/ppb_fullscreen
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105485

[polina, 2011-10-14 01:55:51]

WebKit prerequisite:
https://bugs.webkit.org/show_bug.cgi?id=70076

[darin (slow to review), 2011-10-14 05:03:41]

LGTM

http://codereview.chromium.org/8273029/diff/1/webkit/plugins/ppapi/ppapi_plug...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/8273029/diff/1/webkit/plugins/ppapi/ppapi_plug...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:740: WebKit::WebElement element =
container_->element();
nit: add a 'using WebKit::WebElement' at the top of this file so you can just
say WebElement here.  there is already a using directive for WebDocument, so you
can at least drop the WebKit:: prefix in front of WebDocument.

[darin (slow to review), 2011-10-14 05:06:03]

http://codereview.chromium.org/8273029/diff/1/webkit/plugins/ppapi/ppapi_plug...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/8273029/diff/1/webkit/plugins/ppapi/ppapi_plug...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:742: bool is_fullscreen_element =
(element == document.fullScreenElement());
by the way, to make this easier to land, without having to wait for the webkit
piece to appear first, you can wrap the fullScreenElement() accessor with a
#ifdef.

#ifdef WEBKIT_WEBDOCUMENT_HAS_FULLSCREENELEMENT
...

Then, add that as a #define to WebDocument.h in your WebKit patch.  This way the
patches can land independently.

[polina, 2011-10-14 06:54:06]

http://codereview.chromium.org/8273029/diff/1/webkit/plugins/ppapi/ppapi_plug...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/8273029/diff/1/webkit/plugins/ppapi/ppapi_plug...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:740: WebKit::WebElement element =
container_->element();
On 2011/10/14 05:03:41, darin wrote:
> nit: add a 'using WebKit::WebElement' at the top of this file so you can just
> say WebElement here.  there is already a using directive for WebDocument, so
you
> can at least drop the WebKit:: prefix in front of WebDocument.

Done.

http://codereview.chromium.org/8273029/diff/1/webkit/plugins/ppapi/ppapi_plug...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:742: bool is_fullscreen_element =
(element == document.fullScreenElement());
On 2011/10/14 05:06:03, darin wrote:
> by the way, to make this easier to land, without having to wait for the webkit
> piece to appear first, you can wrap the fullScreenElement() accessor with a
> #ifdef.
> 
> #ifdef WEBKIT_WEBDOCUMENT_HAS_FULLSCREENELEMENT
> ...
> 
> Then, add that as a #define to WebDocument.h in your WebKit patch.  This way
the
> patches can land independently.

Done.

[darin (slow to review), 2011-10-14 07:00:38]

http://codereview.chromium.org/8273029/diff/5002/content/public/renderer/rend...
File content/public/renderer/render_view.h (right):

http://codereview.chromium.org/8273029/diff/5002/content/public/renderer/rend...
content/public/renderer/render_view.h:135: virtual bool IsInFullscreenMode() =
0;
Actually, I don't think this needs to be part of the public API since chrome/
code doesn't need to call this method.  The PepperPluginDelegateImpl has a
pointer to the RenderViewImpl, so IsInFullscreenMode should just be a method on
RenderViewImpl.

[polina, 2011-10-14 07:46:46]

http://codereview.chromium.org/8273029/diff/5002/content/public/renderer/rend...
File content/public/renderer/render_view.h (right):

http://codereview.chromium.org/8273029/diff/5002/content/public/renderer/rend...
content/public/renderer/render_view.h:135: virtual bool IsInFullscreenMode() =
0;
On 2011/10/14 07:00:38, darin wrote:
> Actually, I don't think this needs to be part of the public API since chrome/
> code doesn't need to call this method.  The PepperPluginDelegateImpl has a
> pointer to the RenderViewImpl, so IsInFullscreenMode should just be a method
on
> RenderViewImpl.

Done.

[darin (slow to review), 2011-10-14 07:54:45]

LGTM

http://codereview.chromium.org/8273029/diff/1009/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/8273029/diff/1009/content/renderer/render_view...
content/renderer/render_view_impl.cc:557: bool
RenderViewImpl::IsInFullscreenMode() {
Actually, I plan on making this a method of RenderWidget, but I can take care of
switching it after you land this patch.

[polina, 2011-10-14 12:03:21]

On 2011/10/14 07:54:45, darin wrote:
> LGTM
> 
>
http://codereview.chromium.org/8273029/diff/1009/content/renderer/render_view...
> File content/renderer/render_view_impl.cc (right):
> 
>
http://codereview.chromium.org/8273029/diff/1009/content/renderer/render_view...
> content/renderer/render_view_impl.cc:557: bool
> RenderViewImpl::IsInFullscreenMode() {
> Actually, I plan on making this a method of RenderWidget, but I can take care
of
> switching it after you land this patch.

Committed revision 105485.