Issue 8271010: chromeos: Move BrightnessObserver initialization to the right place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8271010: chromeos: Move BrightnessObserver initialization to the right place. (Closed)

Created:
9 years, 2 months ago by satorux1

Modified:
9 years, 2 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

chromeos: Move BrightnessObserver initialization to the right place. We should do this right after DBusThreadManager is initialized, not at a random place in a huge function in chrome_browser_main.cc. Besides, we should remove the observer before DBusThreadManager is shut down. TEST=brightness controls work as before BUG=chromium-os:16551 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105464

Patch Set 1 #

Patch Set 2 : rebased #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.h	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1	3 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages