Work around lock failure on cygwin.

Work around lock failure on cygwin.

This is really bad but the lock is never held for a long time so it 'should' work.

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105195

[Dirk Pranke, 2011-10-12 23:24:31]

http://codereview.chromium.org/8253008/diff/1/gclient_utils.py
File gclient_utils.py (right):

http://codereview.chromium.org/8253008/diff/1/gclient_utils.py#newcode485
gclient_utils.py:485: self.lock = threading.Lock()
Is changing from an RLock to a Lock intentional? Are you sure it isn't going to
cause you to deadlock?

http://codereview.chromium.org/8253008/diff/1/gclient_utils.py#newcode489
gclient_utils.py:489: self.lock = sys.stdout.lock
Can we wrap this in an if sys.platform == 'cygwin'?

[M-A Ruel, 2011-10-12 23:28:32]

http://codereview.chromium.org/8253008/diff/1/gclient_utils.py
File gclient_utils.py (right):

http://codereview.chromium.org/8253008/diff/1/gclient_utils.py#newcode485
gclient_utils.py:485: self.lock = threading.Lock()
On 2011/10/12 23:24:32, Dirk Pranke wrote:
> Is changing from an RLock to a Lock intentional? Are you sure it isn't going
to
> cause you to deadlock?

It's intentional, the code doesn't have any recursive lock anymore.

http://codereview.chromium.org/8253008/diff/1/gclient_utils.py#newcode489
gclient_utils.py:489: self.lock = sys.stdout.lock
On 2011/10/12 23:24:32, Dirk Pranke wrote:
> Can we wrap this in an if sys.platform == 'cygwin'?

done

[Dirk Pranke, 2011-10-12 23:32:01]

lgtm, thanks.

[commit-bot: I haz the power, 2011-10-12 23:32:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8253008/4001

[commit-bot: I haz the power, 2011-10-12 23:39:32]

Change committed as 105195