Work around lock failure on cygwin.

gclient_utils.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic utils."""
 
 import errno
 import logging
 import os
 import Queue
@@ skipping 463 matching lines @@
     finally:
       self.lock.release()
   return inner
 
 
 class WorkItem(object):
   """One work item."""
   def __init__(self, name):
     # A unique string representing this work item.
     self._name = name
-    self.lock = threading.RLock()
+    try:
+      self.lock = threading.Lock()

[Dirk Pranke, 2011/10/12 23:24:32]

Is changing from an RLock to a Lock intentional? Are you sure it isn't going to
cause you to deadlock?

[M-A Ruel, 2011/10/12 23:28:32]

It's intentional, the code doesn't have any recursive lock anymore.

+    except:  # pylint: disable=W0702
+      # On cygwin, it's throwing randomly. Hack and reuse the single
+      # sys.stdout.lock. Yep you read it right. Single lock.
+      self.lock = sys.stdout.lock

[Dirk Pranke, 2011/10/12 23:24:32]

Can we wrap this in an if sys.platform == 'cygwin'?

[M-A Ruel, 2011/10/12 23:28:32]

done

 
   def run(self, work_queue):
     """work_queue is passed as keyword argument so it should be
     the last parameters of the function when you override it."""
     pass
 
   @property
   def name(self):
     return self._name
 
@@ skipping 163 matching lines @@
         logging.info('Caught exception in thread %s' % self.item.name)
         logging.info(str(sys.exc_info()))
         work_queue.exceptions.put(sys.exc_info())
       logging.info('_Worker.run(%s) done' % self.item.name)
 
       work_queue.ready_cond.acquire()
       try:
         work_queue.ready_cond.notifyAll()
       finally:
         work_queue.ready_cond.release()