Check for compile-time constants in DartCompiler

tests/language/src/StaticFinalFieldTest.dart

Index: tests/language/src/StaticFinalFieldTest.dart
diff --git a/tests/language/src/StaticFinalFieldTest.dart b/tests/language/src/StaticFinalFieldTest.dart
index ecedd6ea00023c327f6b44f7a5c8ae775fa92daf..7cd433372770078d28affd5332b6c2e7b06c3d65 100644
--- a/tests/language/src/StaticFinalFieldTest.dart
+++ b/tests/language/src/StaticFinalFieldTest.dart
@@ -29,7 +29,8 @@ class A implements Switzerland {
   static final architect1 = Spain.AG;
   static final array1 = const <int>[1, 2];
   static final map1 = const {"Monday": 1, "Tuesday": 2, };
-  static final map2 = const {"$s1$s3": b};
+  // Compile time constants don't allow string interpolation.

[ngeoffray, 2011/10/14 09:26:56]

I have CC'ed Matthias to make sure he's aware of that part of the spec (which is
limiting). If we all agree, please move the string interpolation case in a
negative test.

[zundel, 2011/10/14 10:04:21]

For the negative test, see tringInterpolate7NegativeTest.dart

For the String interpolation exclusion in the spec, see section 10.1.  I asked
for it to be changed to allow compile time constant expressions, but never got a
response.

[ngeoffray, 2011/10/14 10:33:42]

Apologies for the "never got a response". Gilad is next to me right now, so it's
easy to get one :) So the spec is limiting right now, but we may extend it once
it gets deeply needed. It hasn't yet because it's not high-priority.

[zundel, 2011/10/14 20:59:52]

I am going ahead and allowing them since the VM does and I've been given a
glimmer of hope that we won't remain this restrictive forever.

[hausner, 2011/10/14 22:20:24]

I was told that string interpolation should not be part of const expressions
after I've implemented it. This is because the toString method is called as a
side effect of every interpolated value, which may have side effects. Someone
some day is going to (ab) use that.

So, I should actually take that functionality out of the VM.


On 2011/10/14 20:59:52, zundel wrote:

+  // static final map2 = const {"$s1$s3": b};
 }
 
 class StaticFinalFieldTest {
@@ -47,7 +48,7 @@ class StaticFinalFieldTest {
     Expect.equals(true, A.artist2 == "Alberto Giacometti");
     Expect.equals(true, A.architect1 == "Antoni Gaudi");
     Expect.equals(2, A.map1["Tuesday"]);
-    Expect.equals(8, A.map2["hulahop"]);
+    // Expect.equals(8, A.map2["hulahop"]);
   }
 }