Check for compile-time constants in DartCompiler

tests/language/src/StaticFinalFieldTest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Dart test program for testing static final fields.
 
 interface Spain {
   static final AG = "Antoni Gaudi";
   static final SD = "Salvador Dali";
 }
 
@@ skipping 11 matching lines @@
   static final d = const A();
   static final s1 = "hula";
   static final s2 = "hula";
   static final s3 = "hop";
   static final d1 = 1.1;
   static final d2 = 0.55 + 0.55;
   static final artist2 = Switzerland.AG;
   static final architect1 = Spain.AG;
   static final array1 = const <int>[1, 2];
   static final map1 = const {"Monday": 1, "Tuesday": 2, };
-  static final map2 = const {"$s1$s3": b};
+  // Compile time constants don't allow string interpolation.

[ngeoffray, 2011/10/14 09:26:56]

I have CC'ed Matthias to make sure he's aware of that part of the spec (which is
limiting). If we all agree, please move the string interpolation case in a
negative test.

[zundel, 2011/10/14 10:04:21]

For the negative test, see tringInterpolate7NegativeTest.dart

For the String interpolation exclusion in the spec, see section 10.1.  I asked
for it to be changed to allow compile time constant expressions, but never got a
response.

[ngeoffray, 2011/10/14 10:33:42]

Apologies for the "never got a response". Gilad is next to me right now, so it's
easy to get one :) So the spec is limiting right now, but we may extend it once
it gets deeply needed. It hasn't yet because it's not high-priority.

[zundel, 2011/10/14 20:59:52]

I am going ahead and allowing them since the VM does and I've been given a
glimmer of hope that we won't remain this restrictive forever.

[hausner, 2011/10/14 22:20:24]

I was told that string interpolation should not be part of const expressions
after I've implemented it. This is because the toString method is called as a
side effect of every interpolated value, which may have side effects. Someone
some day is going to (ab) use that.

So, I should actually take that functionality out of the VM.


On 2011/10/14 20:59:52, zundel wrote:

+  // static final map2 = const {"$s1$s3": b};
 }
 
 class StaticFinalFieldTest {
   static testMain() {
     Expect.equals(15, A.c);
     Expect.equals(8, A.b);
     Expect.equals(5, A.a.n);
     Expect.equals(true,  8 === A.b);
     Expect.equals(true,  A.a === A.d);
     Expect.equals(true,  A.s1 === A.s2);
     Expect.equals(false, A.s1 === A.s3);
     Expect.equals(false, A.s1 === A.b);
     Expect.equals(true,  A.d1 === A.d2);
     Expect.equals(true, Spain.SD == "Salvador Dali");
     Expect.equals(true, A.artist2 == "Alberto Giacometti");
     Expect.equals(true, A.architect1 == "Antoni Gaudi");
     Expect.equals(2, A.map1["Tuesday"]);
-    Expect.equals(8, A.map2["hulahop"]);
+    // Expect.equals(8, A.map2["hulahop"]);
   }
 }
 
 main() {
   StaticFinalFieldTest.testMain();
 }