Make shared memory allocation possible for all child process types.

Make shared memory allocation possible for all child process types.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105621

[michaeln, 2011-10-12 01:50:37]

ptal

[michaeln, 2011-10-12 01:52:54]

http://codereview.chromium.org/8229039/diff/2003/content/renderer/renderer_we...
File content/renderer/renderer_webkitplatformsupport_impl.cc (right):

http://codereview.chromium.org/8229039/diff/2003/content/renderer/renderer_we...
content/renderer/renderer_webkitplatformsupport_impl.cc:608:
blob_registry_.reset(new WebBlobRegistryImpl(ChildThread::current()));
i'll take this file out of this CL and move it to the other CL

[jam, 2011-10-12 03:01:30]

thanks for the cleanup. lgtm with changing size_t back to uint32

http://codereview.chromium.org/8229039/diff/6007/content/common/child_process...
File content/common/child_process_host.h (right):

http://codereview.chromium.org/8229039/diff/6007/content/common/child_process...
content/common/child_process_host.h:164: bool Send(IPC::Message* message) {
return host_->Send(message); }
nit: since the rest of the functions are implemented in the cc file, also put
this along them

http://codereview.chromium.org/8229039/diff/6007/content/common/child_process...
File content/common/child_process_messages.h (right):

http://codereview.chromium.org/8229039/diff/6007/content/common/child_process...
content/common/child_process_messages.h:86: size_t /* buffer size */,
this was a unit32 on purpose, since we want IPC messages to be able to move
between 32 and 64 bit processes, and size_t would be different size

[michaeln, 2011-10-12 06:40:09]

On 2011/10/12 03:01:30, John Abd-El-Malek wrote:
> thanks for the cleanup. lgtm with changing size_t back to uint32

thnx... i'll make those size_t back to uint32 changes (and de-inline) and also
i've got some (small i think) complie errors on gcc to take care of... if
anything material changes i'll ping you to take another look.

[apatrick_chromium, 2011-10-12 19:26:23]

LGTM for content/renderer/gpu