compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java - Issue 8229028: Don't allow a #source directive in a library unit include itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java

Issue 8229028: Don't allow a #source directive in a library unit include itself (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Minor cleanup from previous, removed some debugging code Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java ('k') | compiler/java/com/google/dart/compiler/ast/DartUnit.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java

diff --git a/compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java b/compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java

index f6aa86641a7274e0827eb99e374c62f837538544..dca14d8347746d144d8f1f308c5d53eb8967a267 100644

--- a/compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java

+++ b/compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java

@@ -32,8 +32,8 @@ public class PrettyErrorFormatter extends DefaultErrorFormatter {

public void format(DartCompilationError event) {

Source sourceFile = event.getSource();

- // if no source file is available, default to the basic error formatter

- if (!(sourceFile instanceof DartSource)) {

+ // if this is an unknown source type, default to the basic error formatter

+ if (!(sourceFile instanceof DartSource) && !(sourceFile instanceof LibrarySource)) {

super.format(event);

return;

}