compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java - Issue 8229028: Don't allow a #source directive in a library unit include itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java

Issue 8229028: Don't allow a #source directive in a library unit include itself (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Minor cleanup from previous, removed some debugging code Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/DartCompiler.java ('k') | compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java

diff --git a/compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java b/compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java

index 15ac59c2b6efe98cf849311b6efd5539d4f178a7..f2bc593440e2df6c8b44af14a0bffac981eb24ac 100644

--- a/compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java

+++ b/compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java

@@ -103,7 +103,7 @@ public enum DartCompilerErrorCode implements ErrorCode {

ILLEGAL_ASSIGNMENT_TO_NON_ASSIGNABLE("SyntaxError: Illegal assignment to non-assignable "

+ "expression"),

ILLEGAL_DIRECTIVES_IN_SOURCED_UNIT("A source which was included by another source via a "

- + "#source directive cannot itself contain directives: %s -> %s"),

+ + "#source directive cannot itself contain directives: %s"),

ILLEGAL_FIELD_ACCESS_FROM_STATIC("Illegal access of instance field %s from static scope"),

ILLEGAL_METHOD_ACCESS_FROM_STATIC("Illegal access of instance method %s from static scope"),

ILLEGAL_NUMBER_OF_ARGUMENTS("SyntaxError: Illegal number of arguments"),

@@ -125,7 +125,7 @@ public enum DartCompilerErrorCode implements ErrorCode {

METHOD_MUST_HAVE_BODY("A non-abstract method must have a body"),

MISSING_ARGUMENT("missing argument of type %s"),

MISSING_FUNCTION_NAME("a function name is required for a declaration"),

- MISSING_LIBRARY_DIRECTIVE("a library which was imported into another library is missing a "

+ MISSING_LIBRARY_DIRECTIVE("a library which is imported is missing a "

+ "#library directive: %s"),

MISSING_RETURN_VALUE("no return value; expected a value of type %s"),

MISSING_SOURCE("Cannot find referenced source: %s"),