Issue 8227003: Views Bubble API adjustments and cleanup

Issue 8227003: Views Bubble API adjustments and cleanup (Closed)

Created:
9 years, 2 months ago by msw

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, alicet1, Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa, saintlou

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Views Bubble API adjustments and cleanup Adjust BubbleDelegateView API, add CreateBubble static factory function. Bubble's arrow anchors with a screen point, can fade in and fade out. Supporting changes, test updates, misc related cleanup, -275 lines. BUG=97248, 98322, 98323 TEST=updated unit tests, views_examples bubbles work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106090

Patch Set 1 : Views Bubble cleanup and adjustments. #

Patch Set 2 : Additional fixes and cleanup. #

Patch Set 3 : API Change, test fixes, more cleanup. #

Patch Set 4 : Merge #

Total comments: 1

Patch Set 5 : Fix bubble placement, rename anchor point accessor. #

Patch Set 6 : Add close_on_esc setting and fade-in functionality. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+282 lines, -559 lines)			Patch
M	ui/aura_shell/examples/bubble.cc	View	1 2 3 4 5	2 chunks	+25 lines, -31 lines	0 comments	Download
M	ui/aura_shell/examples/example_factory.h	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download
M	ui/aura_shell/examples/window_type_launcher.cc	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download
M	views/bubble/bubble_border.h	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	views/bubble/bubble_border.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/bubble/bubble_delegate.h	View	1 2 3 4 5	1 chunk	+27 lines, -31 lines	0 comments	Download
M	views/bubble/bubble_delegate.cc	View	1 2 3 4 5	1 chunk	+32 lines, -37 lines	0 comments	Download
M	views/bubble/bubble_delegate_unittest.cc	View	1 2 3 4 5	2 chunks	+7 lines, -28 lines	0 comments	Download
M	views/bubble/bubble_frame_view.h	View	1 2	3 chunks	+9 lines, -29 lines	0 comments	Download
M	views/bubble/bubble_frame_view.cc	View	1 2 3 4	1 chunk	+25 lines, -40 lines	0 comments	Download
M	views/bubble/bubble_frame_view_unittest.cc	View	1 2 3 4 5	2 chunks	+16 lines, -41 lines	0 comments	Download
M	views/bubble/bubble_view.h	View	1 2 3 4 5	2 chunks	+10 lines, -42 lines	0 comments	Download
M	views/bubble/bubble_view.cc	View	1 2 3 4 5	1 chunk	+27 lines, -81 lines	0 comments	Download
M	views/bubble/bubble_view_unittest.cc	View	1 2 3 4 5	2 chunks	+7 lines, -68 lines	0 comments	Download
M	views/examples/bubble_example.h	View	1 2 3 4 5	2 chunks	+5 lines, -28 lines	0 comments	Download
M	views/examples/bubble_example.cc	View	1 2 3 4 5	2 chunks	+67 lines, -76 lines	0 comments	Download
M	views/widget/widget_delegate.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	views/widget/widget_delegate.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	views/window/client_view.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	views/window/client_view.cc	View		2 chunks	+10 lines, -10 lines	0 comments	Download
M	views/window/non_client_view.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

msw

PTAL; thanks! I'm still running tests, but this is ready for review.

9 years, 2 months ago (2011-10-13 17:26:34 UTC) #1

alicet1

LGTM I like the change! just one comment below. thanx, alice http://codereview.chromium.org/8227003/diff/18001/views/bubble/bubble_delegate.h File views/bubble/bubble_delegate.h (right): ...

9 years, 2 months ago (2011-10-14 00:21:17 UTC) #2

msw

Ben: Ping! We're converting bubbles; landing this would help!

9 years, 2 months ago (2011-10-18 01:12:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8227003/30001

9 years, 2 months ago (2011-10-18 16:49:12 UTC) #5

Change committed as 106090

Expand Messages | Collapse Messages