Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: views/window/client_view.cc

Issue 8227003: Views Bubble API adjustments and cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add close_on_esc setting and fade-in functionality. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/window/client_view.h ('k') | views/window/non_client_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/window/client_view.cc
diff --git a/views/window/client_view.cc b/views/window/client_view.cc
index ef65a2149a984a216ff02803ab1a8134811a1673..5b0d0065ef56139d33812b3270eec6c248c3a56f 100644
--- a/views/window/client_view.cc
+++ b/views/window/client_view.cc
@@ -74,14 +74,8 @@ std::string ClientView::GetClassName() const {
return kViewClassName;
}
-void ClientView::ViewHierarchyChanged(bool is_add, View* parent, View* child) {
- if (is_add && child == this) {
- DCHECK(GetWidget());
- DCHECK(contents_view_); // |contents_view_| must be valid now!
- // Insert |contents_view_| at index 0 so it is first in the focus chain.
- // (the OK/Cancel buttons are inserted before contents_view_)
- AddChildViewAt(contents_view_, 0);
- }
+void ClientView::GetAccessibleState(ui::AccessibleViewState* state) {
+ state->role = ui::AccessibilityTypes::ROLE_CLIENT;
}
void ClientView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
@@ -90,8 +84,14 @@ void ClientView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
// NonClientView::Layout.
}
-void ClientView::GetAccessibleState(ui::AccessibleViewState* state) {
- state->role = ui::AccessibilityTypes::ROLE_CLIENT;
+void ClientView::ViewHierarchyChanged(bool is_add, View* parent, View* child) {
+ if (is_add && child == this) {
+ DCHECK(GetWidget());
+ DCHECK(contents_view_); // |contents_view_| must be valid now!
+ // Insert |contents_view_| at index 0 so it is first in the focus chain.
+ // (the OK/Cancel buttons are inserted before contents_view_)
+ AddChildViewAt(contents_view_, 0);
+ }
}
} // namespace views
« no previous file with comments | « views/window/client_view.h ('k') | views/window/non_client_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698