Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/my.no5ref.dart

Issue 8222016: Hashcodes were being improperly calculated for public API of libraries. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Cleanup Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/end2end/inc/my.no5ref.dart
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/my.no5ref.dart b/compiler/javatests/com/google/dart/compiler/end2end/inc/my.no5ref.dart
index e255a53ceab04571b3a172c0f7ac520e65763505..2773973eb4507a5013338e4724f4e2c3550dd78b 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/my.no5ref.dart
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/my.no5ref.dart
@@ -48,3 +48,14 @@ class Foo extends Other2 {
// Reference Other4 using it as a type parameter bound.
class Bar<T extends Other4> {
}
+
+// Test against normalization affecting hashcodes
jbrosenberg 2011/10/11 14:58:44 I'm not sure how this tests against normalization
codefu 2011/10/11 18:43:55 Recap of conversation: Interface gets default cons
+// SomeInterface2 is the interface that gets the default constructor injected
+// by the dartc backend. Just implementing that interface here would only
+// cause a hash inconsistency in this file and we'd only compile this one.
+// By depending on a class that implements the interface in a different
+// file (SomeClass2), we'll see that class fail its hash check and two files be
+// recompiled every time this file is modified.
+class Baz {
+ SomeClass2 sc2;
+}

Powered by Google App Engine
This is Rietveld 408576698