Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/my.dart

Issue 8222016: Hashcodes were being improperly calculated for public API of libraries. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Cleanup Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/end2end/inc/my.dart
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/my.dart b/compiler/javatests/com/google/dart/compiler/end2end/inc/my.dart
index 62ea0d17336e8d3d2d8468984516051dbdbc1643..37bf00cb7bfc98cd11be9a3cb157b055f79f0632 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/my.dart
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/my.dart
@@ -60,3 +60,14 @@ class Foo extends Other2 {
// Reference Other4 using it as a type parameter bound.
class Bar<T extends Other4> {
}
+
+// Test against normalization affecting hashcodes
+// SomeInterface2 is the interface that gets the default constructor injected
+// by the dartc backend. Just implementing that interface here would only
jbrosenberg 2011/10/11 14:58:44 I'm not sure I understand this (what do you mean b
codefu 2011/10/11 18:43:55 normalization adds "(){}" to the interface, corrup
+// cause a hash inconsistency in this file and we'd only compile this one.
+// By depending on a class that implements the interface in a different
+// file (SomeClass2), we'll see that class fail its hash check and two files be
jbrosenberg 2011/10/11 14:58:44 Will we still see this fail, with this fix?
codefu 2011/10/11 18:43:55 good catch.
+// recompiled every time this file is modified.
+class Baz {
+ SomeClass2 sc2;
+}

Powered by Google App Engine
This is Rietveld 408576698