Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: content/public/renderer/render_view_observer.cc

Issue 8220006: Rename RenderView to RenderViewImpl. Update Chrome's DEPS so that it can't include the RenderView... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | content/renderer/device_orientation_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/render_view_observer.cc
===================================================================
--- content/public/renderer/render_view_observer.cc (revision 104727)
+++ content/public/renderer/render_view_observer.cc (working copy)
@@ -4,30 +4,28 @@
#include "content/public/renderer/render_view_observer.h"
-#include "content/renderer/render_view.h"
+#include "content/renderer/render_view_impl.h"
using WebKit::WebFrame;
-// TODO(jam): temporary until RenderView is renamed to RenderViewImpl since
-// trying ::RenderView* below gives compile errors in gcc.
-typedef RenderView RenderViewImpl;
-
namespace content {
RenderViewObserver::RenderViewObserver(RenderView* render_view)
- : render_view_(NULL),
+ : render_view_(render_view),
routing_id_(MSG_ROUTING_NONE) {
// |render_view| can be NULL on unit testing.
if (render_view) {
- render_view_ = static_cast<RenderViewImpl*>(render_view);
- routing_id_ = render_view_->routing_id();
- render_view_->AddObserver(this);
+ RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view);
+ routing_id_ = impl->routing_id();
+ impl->AddObserver(this);
}
}
RenderViewObserver::~RenderViewObserver() {
- if (render_view_)
- render_view_->RemoveObserver(this);
+ if (render_view_) {
+ RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view_);
+ impl->RemoveObserver(this);
+ }
}
void RenderViewObserver::OnDestruct() {
@@ -50,8 +48,8 @@
return render_view_;
}
-void RenderViewObserver::set_render_view(::RenderView* rv) {
- render_view_ = rv;
+void RenderViewObserver::RenderViewGone() {
+ render_view_ = NULL;
}
} // namespace content
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | content/renderer/device_orientation_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698