Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: content/public/renderer/render_view_observer.cc

Issue 8220006: Rename RenderView to RenderViewImpl. Update Chrome's DEPS so that it can't include the RenderView... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/renderer/render_view_observer.h" 5 #include "content/public/renderer/render_view_observer.h"
6 6
7 #include "content/renderer/render_view.h" 7 #include "content/renderer/render_view_impl.h"
8 8
9 using WebKit::WebFrame; 9 using WebKit::WebFrame;
10 10
11 // TODO(jam): temporary until RenderView is renamed to RenderViewImpl since
12 // trying ::RenderView* below gives compile errors in gcc.
13 typedef RenderView RenderViewImpl;
14
15 namespace content { 11 namespace content {
16 12
17 RenderViewObserver::RenderViewObserver(RenderView* render_view) 13 RenderViewObserver::RenderViewObserver(RenderView* render_view)
18 : render_view_(NULL), 14 : render_view_(render_view),
19 routing_id_(MSG_ROUTING_NONE) { 15 routing_id_(MSG_ROUTING_NONE) {
20 // |render_view| can be NULL on unit testing. 16 // |render_view| can be NULL on unit testing.
21 if (render_view) { 17 if (render_view) {
22 render_view_ = static_cast<RenderViewImpl*>(render_view); 18 RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view);
23 routing_id_ = render_view_->routing_id(); 19 routing_id_ = impl->routing_id();
24 render_view_->AddObserver(this); 20 impl->AddObserver(this);
25 } 21 }
26 } 22 }
27 23
28 RenderViewObserver::~RenderViewObserver() { 24 RenderViewObserver::~RenderViewObserver() {
29 if (render_view_) 25 if (render_view_) {
30 render_view_->RemoveObserver(this); 26 RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view_);
27 impl->RemoveObserver(this);
28 }
31 } 29 }
32 30
33 void RenderViewObserver::OnDestruct() { 31 void RenderViewObserver::OnDestruct() {
34 delete this; 32 delete this;
35 } 33 }
36 34
37 bool RenderViewObserver::OnMessageReceived(const IPC::Message& message) { 35 bool RenderViewObserver::OnMessageReceived(const IPC::Message& message) {
38 return false; 36 return false;
39 } 37 }
40 38
41 bool RenderViewObserver::Send(IPC::Message* message) { 39 bool RenderViewObserver::Send(IPC::Message* message) {
42 if (render_view_) 40 if (render_view_)
43 return render_view_->Send(message); 41 return render_view_->Send(message);
44 42
45 delete message; 43 delete message;
46 return false; 44 return false;
47 } 45 }
48 46
49 RenderView* RenderViewObserver::render_view() { 47 RenderView* RenderViewObserver::render_view() {
50 return render_view_; 48 return render_view_;
51 } 49 }
52 50
53 void RenderViewObserver::set_render_view(::RenderView* rv) { 51 void RenderViewObserver::RenderViewGone() {
54 render_view_ = rv; 52 render_view_ = NULL;
55 } 53 }
56 54
57 } // namespace content 55 } // namespace content
OLDNEW
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | content/renderer/device_orientation_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698