Issue 8205023: Move the logging handler hack after the last use of subprocess2 before options are parsed and log...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8205023: Move the logging handler hack after the last use of subprocess2 before options are parsed and log... (Closed)

Created:
9 years, 2 months ago by szym

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, M-A Ruel

CC:
chromium-reviews, Dirk Pranke

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

Move the logging handler hack after the last use of subprocess2 before options are parsed and logging is properly configured with basicConfig. This re-enables git try --verbose/--dry_run. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104633

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	git_try.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/8205023/1

9 years, 2 months ago (2011-10-08 02:15:00 UTC) #2

Change committed as 104633

Expand Messages | Collapse Messages