Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: git_try.py

Issue 8205023: Move the logging handler hack after the last use of subprocess2 before options are parsed and log... (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_try.py
===================================================================
--- git_try.py (revision 104628)
+++ git_try.py (working copy)
@@ -51,11 +51,11 @@
rietveld_url = GetRietveldServerUrl()
if rietveld_url:
args.extend(['--rietveld_url', GetRietveldServerUrl()])
- # Hack around a limitation in logging.
- logging.getLogger().handlers = []
try:
cl = git_cl.Changelist()
change = cl.GetChange(cl.GetUpstreamBranch(), None)
+ # Hack around a limitation in logging.
+ logging.getLogger().handlers = []
sys.exit(trychange.TryChange(
args, change, swallow_exception=False,
prog='git try',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698