(Owner approval for) Delay network requests on startup if any webRequest ...

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
===================================================================
--- chrome/browser/extensions/extension_service.cc	(revision 104705)
+++ chrome/browser/extensions/extension_service.cc	(working copy)
@@ -667,6 +667,15 @@
   return &terminated_extensions_;
 }
 
+void ExtensionService::SetDelaysNetworkRequests(const Extension* extension,
+                                                bool delays) {
+  extension_prefs_->SetDelaysNetworkRequests(extension->id(), delays);
+}
+
+bool ExtensionService::DelaysNetworkRequests(const Extension* extension) const {
+  return extension_prefs_->DelaysNetworkRequests(extension->id());
+}
+
 PendingExtensionManager* ExtensionService::pending_extension_manager() {
   return &pending_extension_manager_;
 }
@@ -2501,6 +2510,12 @@
     extension_prefs_->SetAllowFileAccess(id, true);
   }
 
+  // If the extension should automatically block network startup (e.g., it uses
+  // the webRequest API), set the preference. Otherwise clear it, in case the
+  // extension stopped using a relevant API.
+  SetDelaysNetworkRequests(extension,

[Aaron Boodman, 2011/10/10 22:59:29]

This will definitely clear (as in remove from the file) the preference, right?
It would be a bummer to add a new "delaysNetworkRequests" key for every
extension.

[Pam (message me for reviews), 2011/10/12 14:28:12]

Yes, if false it removes the pref from the ExtensionPrefs dictionary entirely.

+                           extension->ImplicitlyDelaysNetworkStartup());
+
   NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_INSTALLED,
       Source<Profile>(profile_),