(Owner approval for) Delay network requests on startup if any webRequest ...

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 649 matching lines @@
 }
 
 const ExtensionList* ExtensionService::disabled_extensions() const {
   return &disabled_extensions_;
 }
 
 const ExtensionList* ExtensionService::terminated_extensions() const {
   return &terminated_extensions_;
 }
 
+void ExtensionService::SetDelaysNetworkRequests(const Extension* extension,
+                                                bool delays) {
+  extension_prefs_->SetDelaysNetworkRequests(extension->id(), delays);
+}
+
+bool ExtensionService::DelaysNetworkRequests(const Extension* extension) const {
+  return extension_prefs_->DelaysNetworkRequests(extension->id());
+}
+
 PendingExtensionManager* ExtensionService::pending_extension_manager() {
   return &pending_extension_manager_;
 }
 
 void ExtensionService::UnregisterComponentExtension(
     const ComponentExtensionInfo& info) {
   RegisteredComponentExtensions new_component_extension_manifests;
   for (RegisteredComponentExtensions::iterator it =
            component_extension_manifests_.begin();
        it != component_extension_manifests_.end(); ++it) {
@@ skipping 1814 matching lines @@
       from_webstore,
       page_index);
 
   // Unpacked extensions default to allowing file access, but if that has been
   // overridden, don't reset the value.
   if (Extension::ShouldAlwaysAllowFileAccess(extension->location()) &&
       !extension_prefs_->HasAllowFileAccessSetting(id)) {
     extension_prefs_->SetAllowFileAccess(id, true);
   }
 
+  // If the extension should automatically block network startup (e.g., it uses
+  // the webRequest API), set the preference. Otherwise clear it, in case the
+  // extension stopped using a relevant API.
+  SetDelaysNetworkRequests(extension,

[Aaron Boodman, 2011/10/10 22:59:29]

This will definitely clear (as in remove from the file) the preference, right?
It would be a bummer to add a new "delaysNetworkRequests" key for every
extension.

[Pam (message me for reviews), 2011/10/12 14:28:12]

Yes, if false it removes the pref from the ExtensionPrefs dictionary entirely.

+                           extension->ImplicitlyDelaysNetworkStartup());
+
   NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_INSTALLED,
       Source<Profile>(profile_),
       Details<const Extension>(extension));
 
   // Transfer ownership of |extension| to AddExtension.
   AddExtension(scoped_extension);
 }
 
 const Extension* ExtensionService::GetExtensionByIdInternal(
@@ skipping 380 matching lines @@
 
 ExtensionService::NaClModuleInfoList::iterator
     ExtensionService::FindNaClModule(const GURL& url) {
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }