Chromium Code Reviews| Index: chrome/browser/extensions/extension_speech_input_api.h |
| diff --git a/chrome/browser/extensions/extension_speech_input_api.h b/chrome/browser/extensions/extension_speech_input_api.h |
| index 46b8db3ffcbdf03717385c4d82ec57794ce07221..05b30f8d38710ddb810c0cee309105eaa1206c13 100644 |
| --- a/chrome/browser/extensions/extension_speech_input_api.h |
| +++ b/chrome/browser/extensions/extension_speech_input_api.h |
| @@ -16,11 +16,19 @@ class ExtensionSpeechInputManager; |
| class SpeechInputAsyncFunction : public AsyncExtensionFunction, |
| public NotificationObserver { |
| protected: |
| - SpeechInputAsyncFunction(); |
| + SpeechInputAsyncFunction(int start_state, int transition_state, |
| + int end_state, int transition_notification); |
|
Satish
2011/10/09 20:01:47
parameters should either be on the same line or al
Leandro Graciá Gil
2011/10/10 18:59:38
Done.
|
| + virtual ~SpeechInputAsyncFunction(); |
| virtual void Run() OVERRIDE; |
| virtual bool RunImpl() = 0; |
| + // To be defined on construction by derived classes. |
| + const int kStartState_; |
|
Satish
2011/10/09 20:01:47
these can be private as they are not used by the d
Satish
2011/10/09 20:01:47
looking at other code I see the trend is to usuall
Leandro Graciá Gil
2011/10/10 18:59:38
Done.
Leandro Graciá Gil
2011/10/10 18:59:38
Done.
|
| + const int kTransitionState_; |
| + const int kEndState_; |
| + const int kTransitionNotification_; |
| + |
| private: |
| // NotificationObserver. |
| virtual void Observe(int type, |
| @@ -28,10 +36,16 @@ class SpeechInputAsyncFunction : public AsyncExtensionFunction, |
| const NotificationDetails& details) OVERRIDE; |
| NotificationRegistrar registrar_; |
| + bool listening_; |
| + bool failed_; |
| }; |
| // Implements experimental.speechInput.start. |
| class StartSpeechInputFunction : public SpeechInputAsyncFunction { |
| + public: |
| + StartSpeechInputFunction(); |
| + virtual ~StartSpeechInputFunction() {} |
| + |
| protected: |
| virtual bool RunImpl() OVERRIDE; |
| DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.start"); |
| @@ -39,13 +53,17 @@ class StartSpeechInputFunction : public SpeechInputAsyncFunction { |
| // Implements experimental.speechInput.stop. |
| class StopSpeechInputFunction : public SpeechInputAsyncFunction { |
| + public: |
| + StopSpeechInputFunction(); |
| + virtual ~StopSpeechInputFunction() {} |
| + |
| protected: |
| virtual bool RunImpl() OVERRIDE; |
| DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.stop"); |
| }; |
| // Implements experimental.speechInput.isRecording. |
| -class IsRecordingSpeechInputFunction : public SyncIOThreadExtensionFunction { |
| +class IsRecordingSpeechInputFunction : public SyncExtensionFunction { |
| protected: |
| virtual bool RunImpl() OVERRIDE; |
| DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.isRecording"); |