Introducing the basic functionality to the speech input experimental API.

chrome/browser/extensions/extension_speech_input_api.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SPEECH_INPUT_API_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SPEECH_INPUT_API_H_
 #pragma once
 
 #include "chrome/browser/extensions/extension_function.h"
 #include "content/common/notification_service.h"
 
 class ExtensionSpeechInputManager;
 
 // Handles asynchronous operations such as starting or stopping speech
 // recognition in the framework of the extension API state machine.
 class SpeechInputAsyncFunction : public AsyncExtensionFunction,
                                  public NotificationObserver {
  protected:
-  SpeechInputAsyncFunction();
+  SpeechInputAsyncFunction(int start_state, int transition_state,
+      int end_state, int transition_notification);

[Satish, 2011/10/09 20:01:47]

parameters should either be on the same line or aligned together.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Decla...

[Leandro Graciá Gil, 2011/10/10 18:59:38]

Done.

+  virtual ~SpeechInputAsyncFunction();
 
   virtual void Run() OVERRIDE;
   virtual bool RunImpl() = 0;
 
+  // To be defined on construction by derived classes.
+  const int kStartState_;

[Satish, 2011/10/09 20:01:47]

these can be private as they are not used by the derived classes

[Satish, 2011/10/09 20:01:47]

looking at other code I see the trend is to usually have variables like these
(set in constructor) as non-const variables. Could you drop the const for these?

[Leandro Graciá Gil, 2011/10/10 18:59:38]

Done.

[Leandro Graciá Gil, 2011/10/10 18:59:38]

Done.

+  const int kTransitionState_;
+  const int kEndState_;
+  const int kTransitionNotification_;
+
  private:
   // NotificationObserver.
   virtual void Observe(int type,
                        const NotificationSource& source,
                        const NotificationDetails& details) OVERRIDE;
 
   NotificationRegistrar registrar_;
+  bool listening_;
+  bool failed_;
 };
 
 // Implements experimental.speechInput.start.
 class StartSpeechInputFunction : public SpeechInputAsyncFunction {
+ public:
+  StartSpeechInputFunction();
+  virtual ~StartSpeechInputFunction() {}
+
  protected:
   virtual bool RunImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.start");
 };
 
 // Implements experimental.speechInput.stop.
 class StopSpeechInputFunction : public SpeechInputAsyncFunction {
+ public:
+  StopSpeechInputFunction();
+  virtual ~StopSpeechInputFunction() {}
+
  protected:
   virtual bool RunImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.stop");
 };
 
 // Implements experimental.speechInput.isRecording.
-class IsRecordingSpeechInputFunction : public SyncIOThreadExtensionFunction {
+class IsRecordingSpeechInputFunction : public SyncExtensionFunction {
  protected:
   virtual bool RunImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.isRecording");
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SPEECH_INPUT_API_H_