Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 8201001: add missing dependency (Closed)

Created:
9 years, 2 months ago by ensonic
Modified:
9 years ago
Reviewers:
brettw, wan, M-A Ruel, gregoryd
CC:
chromium-reviews, zhanyong.wan
Visibility:
Public.

Description

Move gtest_prod.h into its own target so it can be correctly set as a dependent target for base and reused as a dependency in gtest. R=brettw BUG=105855 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112701

Patch Set 1 : add missing dependency #

Patch Set 2 : gtest: create a small project containing one header which is used from base #

Total comments: 2

Patch Set 3 : gtest: create a small project containing one header which is used from base #

Patch Set 4 : gtest: create a small project containing one header which is used from base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M base/base.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M testing/gtest.gyp View 1 2 3 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 35 (0 generated)
ensonic
9 years, 1 month ago (2011-11-03 10:08:42 UTC) #1
M-A Ruel
Base shouldn't depend on gtest. That's an error if it is the case.
9 years, 1 month ago (2011-11-07 16:28:20 UTC) #2
ensonic
On 2011/11/07 16:28:20, Marc-Antoine Ruel wrote: > Base shouldn't depend on gtest. That's an error ...
9 years, 1 month ago (2011-11-07 17:07:06 UTC) #3
M-A Ruel
On 2011/11/07 17:07:06, ensonic wrote: > On 2011/11/07 16:28:20, Marc-Antoine Ruel wrote: > > Base ...
9 years, 1 month ago (2011-11-07 17:53:20 UTC) #4
ensonic
On 2011/11/07 17:53:20, Marc-Antoine Ruel wrote: > On 2011/11/07 17:07:06, ensonic wrote: > > On ...
9 years, 1 month ago (2011-11-07 18:29:22 UTC) #5
ensonic
Without the patch compilation fails: From //base:base (cc-compile-static) (base/metrics/histogram.cc): In file included from ./base/metrics/histogram.h:51:0, from ...
9 years, 1 month ago (2011-11-08 10:20:17 UTC) #6
M-A Ruel
On 2011/11/08 10:20:17, ensonic wrote: > Without the patch compilation fails: > > From //base:base ...
9 years, 1 month ago (2011-11-08 13:48:30 UTC) #7
ensonic
On 2011/11/08 13:48:30, Marc-Antoine Ruel wrote: > On 2011/11/08 10:20:17, ensonic wrote: > > Without ...
9 years, 1 month ago (2011-11-09 13:08:11 UTC) #8
M-A Ruel
On 2011/11/09 13:08:11, ensonic wrote: > Adding headers from different packages is not possible. What ...
9 years, 1 month ago (2011-11-09 14:23:40 UTC) #9
wan
+Greg, the new owner of gtest. On Wed, Nov 9, 2011 at 6:23 AM, <maruel@chromium.org> ...
9 years, 1 month ago (2011-11-09 15:10:56 UTC) #10
wan
gtest itself only knows about the DISABLED_ prefix. The others are conventions used by Chromium ...
9 years, 1 month ago (2011-11-09 15:13:22 UTC) #11
M-A Ruel
On 2011/11/09 15:13:22, wan wrote: > gtest itself only knows about the DISABLED_ prefix. The ...
9 years, 1 month ago (2011-11-09 15:17:11 UTC) #12
ensonic
On 2011/11/09 15:17:11, Marc-Antoine Ruel wrote: > On 2011/11/09 15:13:22, wan wrote: > > gtest ...
9 years, 1 month ago (2011-11-09 16:42:56 UTC) #13
M-A Ruel
On 2011/11/09 16:42:56, ensonic wrote: > On 2011/11/09 15:17:11, Marc-Antoine Ruel wrote: > > Ok ...
9 years, 1 month ago (2011-11-09 16:45:10 UTC) #14
ensonic
On 2011/11/09 16:45:10, Marc-Antoine Ruel wrote: > On 2011/11/09 16:42:56, ensonic wrote: > > On ...
9 years, 1 month ago (2011-11-14 11:12:25 UTC) #15
M-A Ruel
On 2011/11/14 11:12:25, ensonic wrote: > I am not sure if that was clear. Even ...
9 years, 1 month ago (2011-11-14 17:19:57 UTC) #16
ensonic
On 2011/11/14 17:19:57, Marc-Antoine Ruel wrote: > On 2011/11/14 11:12:25, ensonic wrote: > > I ...
9 years, 1 month ago (2011-11-15 08:40:49 UTC) #17
ensonic
Does the build use a special -D when building tests? Maybe we can put all ...
9 years, 1 month ago (2011-11-15 08:44:00 UTC) #18
M-A Ruel
On 2011/11/15 08:44:00, ensonic wrote: > Does the build use a special -D when building ...
9 years, 1 month ago (2011-11-15 14:29:29 UTC) #19
ensonic
On 2011/11/15 14:29:29, Marc-Antoine Ruel wrote: > On 2011/11/15 08:44:00, ensonic wrote: > > Does ...
9 years, 1 month ago (2011-11-15 14:39:37 UTC) #20
brettw
It's not clear why you're resisting M-A's suggestion of a gtest prod project. That seems ...
9 years, 1 month ago (2011-11-15 18:35:35 UTC) #21
ensonic
On 2011/11/15 18:35:35, brettw wrote: > It's not clear why you're resisting M-A's suggestion of ...
9 years, 1 month ago (2011-11-16 08:27:01 UTC) #22
M-A Ruel
http://codereview.chromium.org/8201001/diff/20001/testing/gtest.gyp File testing/gtest.gyp (right): http://codereview.chromium.org/8201001/diff/20001/testing/gtest.gyp#newcode20 testing/gtest.gyp:20: 'gtest/include/gtest/gtest_prod.h', I'd prefer to have it removed from here ...
9 years ago (2011-11-29 15:22:50 UTC) #23
ensonic
http://codereview.chromium.org/8201001/diff/20001/testing/gtest.gyp File testing/gtest.gyp (right): http://codereview.chromium.org/8201001/diff/20001/testing/gtest.gyp#newcode20 testing/gtest.gyp:20: 'gtest/include/gtest/gtest_prod.h', On 2011/11/29 15:22:51, Marc-Antoine Ruel wrote: > I'd ...
9 years ago (2011-11-30 12:31:54 UTC) #24
ensonic
On 2011/11/30 12:31:54, ensonic wrote: > http://codereview.chromium.org/8201001/diff/20001/testing/gtest.gyp > File testing/gtest.gyp (right): > > http://codereview.chromium.org/8201001/diff/20001/testing/gtest.gyp#newcode20 > ...
9 years ago (2011-12-01 12:52:08 UTC) #25
ensonic
On 2011/12/01 12:52:08, ensonic wrote: > On 2011/11/30 12:31:54, ensonic wrote: > > http://codereview.chromium.org/8201001/diff/20001/testing/gtest.gyp > ...
9 years ago (2011-12-02 09:44:10 UTC) #26
M-A Ruel
lgtm
9 years ago (2011-12-02 12:44:14 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ensonic@google.com/8201001/29001
9 years ago (2011-12-02 12:46:32 UTC) #28
ensonic
9 years ago (2011-12-02 12:46:52 UTC) #29
M-A Ruel
On 2011/12/02 12:44:14, Marc-Antoine Ruel wrote: > lgtm But the description is so-so, this would ...
9 years ago (2011-12-02 12:53:21 UTC) #30
ensonic
On 2011/12/02 12:53:21, Marc-Antoine Ruel wrote: > On 2011/12/02 12:44:14, Marc-Antoine Ruel wrote: > > ...
9 years ago (2011-12-02 13:04:50 UTC) #31
M-A Ruel
On 2011/12/02 13:04:50, ensonic wrote: > My git commits have better messages, but they get ...
9 years ago (2011-12-02 13:10:04 UTC) #32
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
9 years ago (2011-12-02 14:08:04 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ensonic@google.com/8201001/29001
9 years ago (2011-12-02 14:08:34 UTC) #34
commit-bot: I haz the power
9 years ago (2011-12-02 15:27:59 UTC) #35
Change committed as 112701

Powered by Google App Engine
This is Rietveld 408576698