Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 8555003: Subject: [PATCH 09/10] base: remove unused header and include the right one instead (Closed)

Created:
9 years, 1 month ago by ensonic
Modified:
9 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

base: remove unused header and include the right one instead Don't include "base/gtest_prod_util.h". It defines one macro and that is not used here. Include the needed testing header in two places instead. BUG=105855 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112209

Patch Set 1 : base: remove unused header and include the right one instead #

Patch Set 2 : base: remove unused include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/version.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
lgtm
9 years, 1 month ago (2011-11-14 17:15:53 UTC) #1
M-A Ruel
On 2011/11/14 17:15:53, Marc-Antoine Ruel wrote: > lgtm This CL is stale, please sync, you'll ...
9 years ago (2011-11-29 15:24:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ensonic@google.com/8555003/4001
9 years ago (2011-11-30 10:42:47 UTC) #3
ensonic
9 years ago (2011-11-30 10:43:01 UTC) #4
commit-bot: I haz the power
Try job failure for 8555003-4001 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-11-30 10:55:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ensonic@google.com/8555003/6002
9 years ago (2011-11-30 12:23:35 UTC) #6
ensonic
9 years ago (2011-11-30 12:23:40 UTC) #7
commit-bot: I haz the power
9 years ago (2011-11-30 13:27:08 UTC) #8
Change committed as 112209

Powered by Google App Engine
This is Rietveld 408576698