Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 8198013: Fix the bug that closing a tab which owns a fullscreen Flash widget causes crash. (Closed)

Created:
9 years, 2 months ago by yzshen1
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam
Visibility:
Public.

Description

Fix the bug that closing a tab which owns a fullscreen Flash widget causes crash. BUG=NONE TEST=1. goes to http://www.vimeo.com/hd 2. play any video and enter fullscreen mode. 3. right click to open Flash context menu. 4. choose Global Settings..., which causes the browser window to be brought to the foreground. 5. close the tab of http://www.vimeo.com/hd 6. the settings page should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104693

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make changes in response to Antoine's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 7 chunks +22 lines, -12 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yzshen1
Hi, Antoine. Please review this CL. Thanks!
9 years, 2 months ago (2011-10-07 22:11:02 UTC) #1
piman
lgtm LGTM http://codereview.chromium.org/8198013/diff/1/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (right): http://codereview.chromium.org/8198013/diff/1/content/renderer/render_widget_fullscreen_pepper.cc#newcode192 content/renderer/render_widget_fullscreen_pepper.cc:192: (widget_->plugin()->GetBackingTextureId() != 0); nit: indentation (4 spaces).
9 years, 2 months ago (2011-10-07 22:36:22 UTC) #2
yzshen1
Thanks, Antoine! http://codereview.chromium.org/8198013/diff/1/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (right): http://codereview.chromium.org/8198013/diff/1/content/renderer/render_widget_fullscreen_pepper.cc#newcode192 content/renderer/render_widget_fullscreen_pepper.cc:192: (widget_->plugin()->GetBackingTextureId() != 0); On 2011/10/07 22:36:22, piman ...
9 years, 2 months ago (2011-10-07 22:48:14 UTC) #3
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/8198013/3001
9 years, 2 months ago (2011-10-10 03:40:49 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-10-10 05:06:54 UTC) #5
Change committed as 104693

Powered by Google App Engine
This is Rietveld 408576698