webkit/plugins/ppapi/ppapi_plugin_instance.cc - Issue 8198013: Fix the bug that closing a tab which owns a fullscreen Flash widget causes crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 8198013: Fix the bug that closing a tab which owns a fullscreen Flash widget causes crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make changes in response to Antoine's comments. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc

diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc

index 6df29eee00de3611a04dcc1ac5614035d078150e..3da10c702e3cc3782c58812954fe3aec008feb5d 100644

--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc

+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc

@@ -260,6 +260,8 @@ PluginInstance::PluginInstance(

}

PluginInstance::~PluginInstance() {

+ DCHECK(!fullscreen_container_);

// Free all the plugin objects. This will automatically clear the back-

// pointer from the NPObject so WebKit can't call into the plugin any more.

« no previous file with comments | « content/renderer/render_widget_fullscreen_pepper.cc ('k') | no next file » | no next file with comments »