chrome/browser/importer/profile_writer.cc - Issue 8198007: Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/profile_writer.cc

Issue 8198007: Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix chromeos Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/accessibility_util.cc ('K') | « chrome/browser/geolocation/chrome_geolocation_permission_context.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/profile_writer.cc

diff --git a/chrome/browser/importer/profile_writer.cc b/chrome/browser/importer/profile_writer.cc

index ab414e551a3bd3faf16a329bcc29fe93137e356d..fc0f954013afffe5b09f0b627b6e658c9beb9839 100644

--- a/chrome/browser/importer/profile_writer.cc

+++ b/chrome/browser/importer/profile_writer.cc

@@ -56,12 +56,7 @@ string16 GenerateUniqueFolderName(BookmarkModel* model,

// Shows the bookmarks toolbar.

void ShowBookmarkBar(Profile* profile) {

- PrefService* prefs = profile->GetPrefs();

- // Check whether the bookmark bar is shown in current pref.

- if (!prefs->GetBoolean(prefs::kShowBookmarkBar)) {

- prefs->SetBoolean(prefs::kShowBookmarkBar, true);

- prefs->ScheduleSavePersistentPrefs();

- }

+ profile->GetPrefs()->SetBoolean(prefs::kShowBookmarkBar, true);

}

} // namespace

@@ -106,7 +101,6 @@ void ProfileWriter::AddHomepage(const GURL& home_page) {

const PrefService::Preference* pref = prefs->FindPreference(prefs::kHomePage);

if (pref && !pref->IsManaged()) {

prefs->SetString(prefs::kHomePage, home_page.spec());

- prefs->ScheduleSavePersistentPrefs();

}