Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3824)

Unified Diff: chrome/browser/chromeos/user_cros_settings_provider.cc

Issue 8198007: Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chromeos Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/user_cros_settings_provider.cc
diff --git a/chrome/browser/chromeos/user_cros_settings_provider.cc b/chrome/browser/chromeos/user_cros_settings_provider.cc
index 764c846dfc0179a0aba5a5ac833e831f94d1cb53..f00688b4e600484baa9114a2aad78bff30a8c528 100644
--- a/chrome/browser/chromeos/user_cros_settings_provider.cc
+++ b/chrome/browser/chromeos/user_cros_settings_provider.cc
@@ -196,7 +196,6 @@ void UpdateCacheBool(const std::string& name,
prefs->ClearPref(name.c_str());
else
prefs->SetBoolean(name.c_str(), value);
- prefs->ScheduleSavePersistentPrefs();
}
void UpdateCacheString(const std::string& name,
@@ -207,7 +206,6 @@ void UpdateCacheString(const std::string& name,
prefs->ClearPref(name.c_str());
else
prefs->SetString(name.c_str(), value);
- prefs->ScheduleSavePersistentPrefs();
}
bool GetUserWhitelist(ListValue* user_list) {
@@ -240,7 +238,6 @@ bool GetUserWhitelist(ListValue* user_list) {
cached_whitelist_update->Append(Value::CreateStringValue(email));
}
- prefs->ScheduleSavePersistentPrefs();
return true;
}
@@ -425,7 +422,6 @@ class UserCrosSettingsTrust : public SignedSettingsHelper::Callback {
return;
// Do not trust before fetching complete.
prefs->ClearPref((name + kTrustedSuffix).c_str());
- prefs->ScheduleSavePersistentPrefs();
if (CrosLibrary::Get()->EnsureLoaded()) {
SignedSettingsHelper::Get()->StartRetrieveProperty(name, this);
}
@@ -731,7 +727,6 @@ void UserCrosSettingsProvider::WhitelistUser(const std::string& email) {
PrefService* prefs = g_browser_process->local_state();
ListPrefUpdate cached_whitelist_update(prefs, kAccountsPrefUsers);
cached_whitelist_update->Append(Value::CreateStringValue(email));
- prefs->ScheduleSavePersistentPrefs();
}
void UserCrosSettingsProvider::UnwhitelistUser(const std::string& email) {
@@ -741,8 +736,7 @@ void UserCrosSettingsProvider::UnwhitelistUser(const std::string& email) {
PrefService* prefs = g_browser_process->local_state();
ListPrefUpdate cached_whitelist_update(prefs, kAccountsPrefUsers);
StringValue email_value(email);
- if (cached_whitelist_update->Remove(email_value, NULL))
- prefs->ScheduleSavePersistentPrefs();
+ cached_whitelist_update->Remove(email_value, NULL);
}
// static

Powered by Google App Engine
This is Rietveld 408576698