chrome/browser/extensions/crx_installer.h - Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Adding constness and comments Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/crx_installer.h

diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h

index 4938388b53bb86b1f140e5e86cf25add6f13298d..aa3a970fd6aa192092338ca861d2b50374f03882 100644

--- a/chrome/browser/extensions/crx_installer.h

+++ b/chrome/browser/extensions/crx_installer.h

@@ -16,6 +16,7 @@

#include "chrome/browser/extensions/extension_install_ui.h"

#include "chrome/browser/extensions/sandboxed_extension_unpacker.h"

#include "chrome/common/extensions/extension.h"

+#include "chrome/common/string_ordinal.h"

#include "chrome/common/web_apps.h"

class ExtensionService;

@@ -177,7 +178,7 @@ class CrxInstaller

install_cause_ = install_cause;

}

- void set_page_index(int page_index) {

+ void set_page_index(StringOrdinal page_index) {

akalin 2011/11/17 03:06:32 const ref

csharp 2011/11/17 19:51:58 Done.

page_index_ = page_index;

}

@@ -272,7 +273,7 @@ class CrxInstaller

scoped_refptr<const Extension> extension_;

// The index of the NTP apps page |extension_| will be shown on.

- int page_index_;

+ StringOrdinal page_index_;

// A parsed copy of the unmodified original manifest, before any

// transformations like localization have taken place.

« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/browser/extensions/extension_prefs.h » ('J')