Convert app_launch_index and page_index from int to StringOrdinal.

chrome/browser/extensions/crx_installer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #pragma once
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/version.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/sandboxed_extension_unpacker.h"
 #include "chrome/common/extensions/extension.h"
+#include "chrome/common/string_ordinal.h"
 #include "chrome/common/web_apps.h"
 
 class ExtensionService;
 class SkBitmap;
 
 // This class installs a crx file into a profile.
 //
 // Installing a CRX is a multi-step process, including unpacking the crx,
 // validating it, prompting the user, and installing. Since many of these
 // steps must occur on the file thread, this class contains a copy of all data
@@ skipping 141 matching lines @@
   }
 
   extension_misc::CrxInstallCause install_cause() const {
     return install_cause_;
   }
 
   void set_install_cause(extension_misc::CrxInstallCause install_cause) {
     install_cause_ = install_cause;
   }
 
-  void set_page_index(int page_index) {
+  void set_page_index(StringOrdinal page_index) {

[akalin, 2011/11/17 03:06:32]

const ref

[csharp, 2011/11/17 19:51:58]

Done.

     page_index_ = page_index;
   }
 
   Profile* profile() { return profile_; }
 
  private:
   friend class ExtensionUpdaterTest;
 
   CrxInstaller(base::WeakPtr<ExtensionService> frontend_weak,
                ExtensionInstallUI* client);
@@ skipping 74 matching lines @@
   // Whether to create an app shortcut after successful installation. This is
   // set based on the user's selection in the UI and can only ever be true for
   // apps.
   bool create_app_shortcut_;
 
   // The extension we're installing. We own this and either pass it off to
   // ExtensionService on success, or delete it on failure.
   scoped_refptr<const Extension> extension_;
 
   // The index of the NTP apps page |extension_| will be shown on.
-  int page_index_;
+  StringOrdinal page_index_;
 
   // A parsed copy of the unmodified original manifest, before any
   // transformations like localization have taken place.
   scoped_ptr<base::DictionaryValue> original_manifest_;
 
   // If non-empty, contains the current version of the extension we're
   // installing (for upgrades).
   std::string current_version_;
 
   // The icon we will display in the installation UI, if any.
@@ skipping 39 matching lines @@
   extension_misc::CrxInstallCause install_cause_;
 
   // Creation flags to use for the extension.  These flags will be used
   // when calling Extenion::Create() by the crx installer.
   int creation_flags_;
 
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_