chrome/browser/extensions/test_extension_prefs.cc - Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/test_extension_prefs.cc

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Changing strings to StringOrdinals Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_prefs.cc ('K') | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | chrome/browser/resources/ntp4/new_tab.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/test_extension_prefs.cc

diff --git a/chrome/browser/extensions/test_extension_prefs.cc b/chrome/browser/extensions/test_extension_prefs.cc

index a95be5982a92f5373fb295b0f6b3a7203fd0e71c..01142f79137a964c439121691c5732b38877d054 100644

--- a/chrome/browser/extensions/test_extension_prefs.cc

+++ b/chrome/browser/extensions/test_extension_prefs.cc

@@ -139,7 +139,8 @@ scoped_refptr<Extension> TestExtensionPrefs::AddExtensionWithManifestAndFlags(

EXPECT_TRUE(Extension::IdIsValid(extension->id()));

prefs_->OnExtensionInstalled(extension, Extension::ENABLED,

- extra_flags & Extension::FROM_WEBSTORE, 0);

+ extra_flags & Extension::FROM_WEBSTORE,

+ StringOrdinal::CreateValidOrdinal());

return extension;

}